Replace calls to assert() with RTC_DCHECK_*() in .c code

Replace calls to assert() with RTC_DCHECK_*() in .c code

We have RTC_CHECK and RTC_DCHECK for C now, so we should use it. It's
one fewer difference between our C and C++ code.

NOPRESUBMIT=true

Committed: https://crrev.com/1e8ed4a801509f5ea31f98f1f4822dba71be9f8e
Cr-Commit-Position: refs/heads/master@{#13930}

[kwiberg-webrtc, 2016-08-24 21:55:00]

kwiberg@webrtc.org changed reviewers:
+ ossu@webrtc.org

[ossu, 2016-08-25 13:38:22]

https://codereview.webrtc.org/2274083002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/codecs/isac/isac_test.gypi (right):

https://codereview.webrtc.org/2274083002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/codecs/isac/isac_test.gypi:26: 'empty.cc',  # force
build system to use C++ linker
Why?

[kwiberg-webrtc, 2016-08-25 16:53:10]

https://codereview.webrtc.org/2274083002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/codecs/isac/isac_test.gypi (right):

https://codereview.webrtc.org/2274083002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/codecs/isac/isac_test.gypi:26: 'empty.cc',  # force
build system to use C++ linker
On 2016/08/25 13:38:22, ossu wrote:
> Why?

Because simplicity, the C RTC_DCHECK macro calls the same function as the C++
RTC_DCHECK macro. It uses a bunch of stuff from the C++ standard library.

This is only a problem for a tiny number of test binaries like this one whose
top level code is in C.

[ossu, 2016-08-26 08:11:27]

On 2016/08/25 16:53:10, kwiberg-webrtc wrote:
>
https://codereview.webrtc.org/2274083002/diff/20001/webrtc/modules/audio_codi...
> File webrtc/modules/audio_coding/codecs/isac/isac_test.gypi (right):
> 
>
https://codereview.webrtc.org/2274083002/diff/20001/webrtc/modules/audio_codi...
> webrtc/modules/audio_coding/codecs/isac/isac_test.gypi:26: 'empty.cc',  #
force
> build system to use C++ linker
> On 2016/08/25 13:38:22, ossu wrote:
> > Why?
> 
> Because simplicity, the C RTC_DCHECK macro calls the same function as the C++
> RTC_DCHECK macro. It uses a bunch of stuff from the C++ standard library.
> 
> This is only a problem for a tiny number of test binaries like this one whose
> top level code is in C.

Ah, alright. I see know the call to rtc::FatalMessage in the previous CL. I
guess it makes sense, rather than reimplementing this functionality in pure C as
well. LGTM

[kwiberg-webrtc, 2016-08-26 08:46:26]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-08-26 08:46:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-26 09:00:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 09:00:47]

Try jobs failed on following builders:
  android_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/15852)

[kwiberg-webrtc, 2016-08-26 09:09:15]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-08-26 09:09:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-26 10:47:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 10:47:03]

Try jobs failed on following builders:
  mac_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[kwiberg-webrtc, 2016-08-26 11:12:28]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-08-26 11:12:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-26 11:33:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-26 11:33:49]

Description was changed from

==========
Replace calls to assert() with RTC_DCHECK_*() in .c code

We have RTC_CHECK and RTC_DCHECK for C now, so we should use it. It's
one fewer difference between our C and C++ code.

NOPRESUBMIT=true
==========

to

==========
Replace calls to assert() with RTC_DCHECK_*() in .c code

We have RTC_CHECK and RTC_DCHECK for C now, so we should use it. It's
one fewer difference between our C and C++ code.

NOPRESUBMIT=true

Committed: https://crrev.com/1e8ed4a801509f5ea31f98f1f4822dba71be9f8e
Cr-Commit-Position: refs/heads/master@{#13930}
==========

[commit-bot: I haz the power, 2016-08-26 11:33:51]

Patchset 2 (id:??) landed as
https://crrev.com/1e8ed4a801509f5ea31f98f1f4822dba71be9f8e
Cr-Commit-Position: refs/heads/master@{#13930}