webrtc/common_audio/signal_processing/min_max_operations_mips.c - Issue 2274083002: Replace calls to assert() with RTC_DCHECK_*() in .c code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/common_audio/signal_processing/min_max_operations_mips.c

Issue 2274083002: Replace calls to assert() with RTC_DCHECK_*() in .c code (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/common_audio/signal_processing/min_max_operations.c ('k') | webrtc/common_audio/signal_processing/min_max_operations_neon.c » ('j') | webrtc/modules/audio_coding/codecs/isac/isac_test.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/common_audio/signal_processing/min_max_operations_mips.c

diff --git a/webrtc/common_audio/signal_processing/min_max_operations_mips.c b/webrtc/common_audio/signal_processing/min_max_operations_mips.c

index 28de45b3a5e6e87f09e554167e86ed6b4359c5b8..c769e6a9d4d07f620e682a43dd934eb896867f65 100644

--- a/webrtc/common_audio/signal_processing/min_max_operations_mips.c

+++ b/webrtc/common_audio/signal_processing/min_max_operations_mips.c

@@ -16,8 +16,7 @@

-#include <assert.h>

+#include "webrtc/base/checks.h"

#include "webrtc/common_audio/signal_processing/include/signal_processing_library.h"

// Maximum absolute value of word16 vector.

@@ -26,7 +25,7 @@ int16_t WebRtcSpl_MaxAbsValueW16_mips(const int16_t* vector, size_t length) {

int32_t tmp32_0, tmp32_1, tmp32_2, tmp32_3;

size_t i, loop_size;

- assert(length > 0);

+ RTC_DCHECK_GT(length, 0);

#if defined(MIPS_DSP_R1)

const int32_t* tmpvec32 = (int32_t*)vector;

@@ -230,7 +229,7 @@ int32_t WebRtcSpl_MaxAbsValueW32_mips(const int32_t* vector, size_t length) {

uint32_t absolute = 0, maximum = 0;

int tmp1 = 0, max_value = 0x7fffffff;

- assert(length > 0);

+ RTC_DCHECK_GT(length, 0);

__asm__ volatile (

".set push \n\t"

@@ -264,7 +263,7 @@ int16_t WebRtcSpl_MaxValueW16_mips(const int16_t* vector, size_t length) {

int tmp1;

int16_t value;

- assert(length > 0);

+ RTC_DCHECK_GT(length, 0);

__asm__ volatile (

".set push \n\t"

@@ -292,7 +291,7 @@ int32_t WebRtcSpl_MaxValueW32_mips(const int32_t* vector, size_t length) {

int32_t maximum = WEBRTC_SPL_WORD32_MIN;

int tmp1, value;

- assert(length > 0);

+ RTC_DCHECK_GT(length, 0);

__asm__ volatile (

".set push \n\t"

@@ -322,7 +321,7 @@ int16_t WebRtcSpl_MinValueW16_mips(const int16_t* vector, size_t length) {

int tmp1;

int16_t value;

- assert(length > 0);

+ RTC_DCHECK_GT(length, 0);

__asm__ volatile (

".set push \n\t"

@@ -351,7 +350,7 @@ int32_t WebRtcSpl_MinValueW32_mips(const int32_t* vector, size_t length) {

int32_t minimum = WEBRTC_SPL_WORD32_MAX;

int tmp1, value;

- assert(length > 0);

+ RTC_DCHECK_GT(length, 0);

__asm__ volatile (

".set push \n\t"