webrtc/common_audio/vad/vad_sp.c - Issue 2274083002: Replace calls to assert() with RTC_DCHECK_*() in .c code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/common_audio/vad/vad_sp.c

Issue 2274083002: Replace calls to assert() with RTC_DCHECK_*() in .c code (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/common_audio/vad/vad_filterbank.c ('k') | webrtc/modules/audio_coding/codecs/isac/empty.cc » ('j') | webrtc/modules/audio_coding/codecs/isac/isac_test.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/common_audio/vad/vad_sp.c

diff --git a/webrtc/common_audio/vad/vad_sp.c b/webrtc/common_audio/vad/vad_sp.c

index a54be17daacae5eaf97ec09db0c71efc7d8e31e9..4a1cebb0d5b77d5356b49e6798cd37721937744b 100644

--- a/webrtc/common_audio/vad/vad_sp.c

+++ b/webrtc/common_audio/vad/vad_sp.c

@@ -10,8 +10,7 @@

#include "webrtc/common_audio/vad/vad_sp.h"

-#include <assert.h>

+#include "webrtc/base/checks.h"

#include "webrtc/common_audio/signal_processing/include/signal_processing_library.h"

#include "webrtc/common_audio/vad/vad_core.h"

#include "webrtc/typedefs.h"

@@ -72,7 +71,7 @@ int16_t WebRtcVad_FindMinimum(VadInstT* self,

int16_t* age = &self->index_vector[offset];

int16_t* smallest_values = &self->low_value_vector[offset];

- assert(channel < kNumChannels);

+ RTC_DCHECK_LT(channel, kNumChannels);

// Each value in |smallest_values| is getting 1 loop older. Update |age|, and

// remove old values.