webrtc/modules/audio_processing/ns/nsx_core_mips.c - Issue 2274083002: Replace calls to assert() with RTC_DCHECK_*() in .c code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/ns/nsx_core_mips.c

Issue 2274083002: Replace calls to assert() with RTC_DCHECK_*() in .c code (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_coding/codecs/isac/isac_test.gypi ('K') | « webrtc/modules/audio_processing/ns/nsx_core_c.c ('k') | webrtc/modules/audio_processing/ns/nsx_core_neon.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/ns/nsx_core_mips.c

diff --git a/webrtc/modules/audio_processing/ns/nsx_core_mips.c b/webrtc/modules/audio_processing/ns/nsx_core_mips.c

index 3922308c7c8dd3531b5a55fa777492aaef58c005..2baf7dfa9e13a638a645aba811eb298052695439 100644

--- a/webrtc/modules/audio_processing/ns/nsx_core_mips.c

+++ b/webrtc/modules/audio_processing/ns/nsx_core_mips.c

@@ -8,9 +8,9 @@

* be found in the AUTHORS file in the root of the source tree.

-#include <assert.h>

#include <string.h>

+#include "webrtc/base/checks.h"

#include "webrtc/modules/audio_processing/ns/noise_suppression_x.h"

#include "webrtc/modules/audio_processing/ns/nsx_core.h"

@@ -184,7 +184,7 @@ void WebRtcNsx_SpeechNoiseProb(NoiseSuppressionFixedC* inst,

if (inst->featureSpecDiff) {

normTmp = WEBRTC_SPL_MIN(20 - inst->stages,

WebRtcSpl_NormU32(inst->featureSpecDiff));

- assert(normTmp >= 0);

+ RTC_DCHECK_GE(normTmp, 0);

tmpU32no1 = inst->featureSpecDiff << normTmp; // Q(normTmp-2*stages)

tmpU32no2 = inst->timeAvgMagnEnergy >> (20 - inst->stages - normTmp);

if (tmpU32no2 > 0) {