webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding_neon.c - Issue 2274083002: Replace calls to assert() with RTC_DCHECK_*() in .c code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding_neon.c

Issue 2274083002: Replace calls to assert() with RTC_DCHECK_*() in .c code (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/codecs/isac/fix/source/encode.c ('k') | webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks.c » ('j') | webrtc/modules/audio_coding/codecs/isac/isac_test.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding_neon.c

diff --git a/webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding_neon.c b/webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding_neon.c

index 0f01a030cb72397e102aa76f44781fe764f213fc..1e4812aad3f9185f3740abeed50a47f8cdaa88b5 100644

--- a/webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding_neon.c

+++ b/webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding_neon.c

@@ -17,10 +17,10 @@

#include "entropy_coding.h"

#include <arm_neon.h>

-#include <assert.h>

#include <stddef.h>

#include "signal_processing_library.h"

+#include "webrtc/base/checks.h"

void WebRtcIsacfix_MatrixProduct1Neon(const int16_t matrix0[],

const int32_t matrix1[],

@@ -46,8 +46,8 @@ void WebRtcIsacfix_MatrixProduct1Neon(const int16_t matrix0[],

int32x4_t sum_32x4 = vdupq_n_s32(0);

int32x2_t sum_32x2 = vdup_n_s32(0);

- assert(inner_loop_count % 2 == 0);

- assert(mid_loop_count % 2 == 0);

+ RTC_DCHECK_EQ(0, inner_loop_count % 2);

+ RTC_DCHECK_EQ(0, mid_loop_count % 2);

if (matrix1_index_init_case != 0 && matrix1_index_factor1 == 1) {

for (j = 0; j < SUBFRAMES; j++) {