webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks.c - Issue 2274083002: Replace calls to assert() with RTC_DCHECK_*() in .c code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks.c

Issue 2274083002: Replace calls to assert() with RTC_DCHECK_*() in .c code (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding_neon.c ('k') | webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_neon.c » ('j') | webrtc/modules/audio_coding/codecs/isac/isac_test.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks.c

diff --git a/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks.c b/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks.c

index 2e92578cf7f2d97b6186fc6ec5d738e30978bd13..ce479e2777da059d4805fe0f48d18994144fffc4 100644

--- a/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks.c

+++ b/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks.c

@@ -20,11 +20,10 @@

#include "filterbank_internal.h"

-#include <assert.h>

#include "codec.h"

#include "filterbank_tables.h"

#include "settings.h"

+#include "webrtc/base/checks.h"

// Declare a function pointer.

AllpassFilter2FixDec16 WebRtcIsacfix_AllpassFilter2FixDec16;

@@ -44,7 +43,7 @@ void WebRtcIsacfix_AllpassFilter2FixDec16C(

int32_t a = 0, b = 0;

// Assembly file assumption.

- assert(length % 2 == 0);

+ RTC_DCHECK_EQ(0, length % 2);

for (n = 0; n < length; n++) {

// Process channel 1: