webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_neon.c - Issue 2274083002: Replace calls to assert() with RTC_DCHECK_*() in .c code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_neon.c

Issue 2274083002: Replace calls to assert() with RTC_DCHECK_*() in .c code (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks.c ('k') | webrtc/modules/audio_coding/codecs/isac/fix/source/filters.c » ('j') | webrtc/modules/audio_coding/codecs/isac/isac_test.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_neon.c

diff --git a/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_neon.c b/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_neon.c

index 20f80aefec74ebd801326da165db1065a36457e2..5dd6e8fe97906e95e1558e801c217bd9d4cf14c7 100644

--- a/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_neon.c

+++ b/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_neon.c

@@ -14,7 +14,8 @@

// C code is at end of this file.

#include <arm_neon.h>

-#include <assert.h>

+#include "webrtc/base/checks.h"

void WebRtcIsacfix_AllpassFilter2FixDec16Neon(

int16_t* data_ch1, // Input and output in channel 1, in Q0

@@ -24,7 +25,7 @@ void WebRtcIsacfix_AllpassFilter2FixDec16Neon(

const int length, // Length of the data buffers

int32_t* filter_state_ch1, // Filter state for channel 1, in Q16

int32_t* filter_state_ch2) { // Filter state for channel 2, in Q16

- assert(length % 2 == 0);

+ RTC_DCHECK_EQ(0, length % 2);

int n = 0;

int16x4_t factorv;

int16x4_t datav;