webrtc/modules/audio_coding/codecs/isac/fix/source/filters.c - Issue 2274083002: Replace calls to assert() with RTC_DCHECK_*() in .c code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/isac/fix/source/filters.c

Issue 2274083002: Replace calls to assert() with RTC_DCHECK_*() in .c code (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_neon.c ('k') | webrtc/modules/audio_coding/codecs/isac/fix/source/filters_neon.c » ('j') | webrtc/modules/audio_coding/codecs/isac/isac_test.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/isac/fix/source/filters.c

diff --git a/webrtc/modules/audio_coding/codecs/isac/fix/source/filters.c b/webrtc/modules/audio_coding/codecs/isac/fix/source/filters.c

index 21e49830a1ae9b060c4eaa4d37ff9d5ca81e1b84..2e666d6397089fb64c83caa07bee8ca11ce570bb 100644

--- a/webrtc/modules/audio_coding/codecs/isac/fix/source/filters.c

+++ b/webrtc/modules/audio_coding/codecs/isac/fix/source/filters.c

@@ -8,8 +8,7 @@

* be found in the AUTHORS file in the root of the source tree.

-#include <assert.h>

+#include "webrtc/base/checks.h"

#include "webrtc/modules/audio_coding/codecs/isac/fix/source/codec.h"

// Autocorrelation function in fixed point.

@@ -27,8 +26,8 @@ int WebRtcIsacfix_AutocorrC(int32_t* __restrict r,

int64_t prod = 0;

// The ARM assembly code assumptoins.

- assert(N % 4 == 0);

- assert(N >= 8);

+ RTC_DCHECK_EQ(0, N % 4);

+ RTC_DCHECK_GE(N, 8);

// Calculate r[0].

for (i = 0; i < N; i++) {