webrtc/common_audio/signal_processing/filter_ar_fast_q12_mips.c - Issue 2274083002: Replace calls to assert() with RTC_DCHECK_*() in .c code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/common_audio/signal_processing/filter_ar_fast_q12_mips.c

Issue 2274083002: Replace calls to assert() with RTC_DCHECK_*() in .c code (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/common_audio/signal_processing/filter_ar_fast_q12.c ('k') | webrtc/common_audio/signal_processing/min_max_operations.c » ('j') | webrtc/modules/audio_coding/codecs/isac/isac_test.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/common_audio/signal_processing/filter_ar_fast_q12_mips.c

diff --git a/webrtc/common_audio/signal_processing/filter_ar_fast_q12_mips.c b/webrtc/common_audio/signal_processing/filter_ar_fast_q12_mips.c

index 03847018e3daa7aaa10a6e96f40ea99ed1d00160..02fa80b05628456e0c2062d80eba5554ba978d03 100644

--- a/webrtc/common_audio/signal_processing/filter_ar_fast_q12_mips.c

+++ b/webrtc/common_audio/signal_processing/filter_ar_fast_q12_mips.c

@@ -7,8 +7,8 @@

* in the file PATENTS. All contributing project authors may

* be found in the AUTHORS file in the root of the source tree.

-#include <assert.h>

+#include "webrtc/base/checks.h"

#include "webrtc/common_audio/signal_processing/include/signal_processing_library.h"

void WebRtcSpl_FilterARFastQ12(const int16_t* data_in,

@@ -25,8 +25,8 @@ void WebRtcSpl_FilterARFastQ12(const int16_t* data_in,

int min16 = 0xFFFF8000;

#endif // #if !defined(MIPS_DSP_R1_LE)

- assert(data_length > 0);

- assert(coefficients_length > 1);

+ RTC_DCHECK_GT(data_length, 0);

+ RTC_DCHECK_GT(coefficients_length, 1);

__asm __volatile (

".set push \n\t"