Removing some old code which looked like it had to do with NACK handling but in reality did nothing.

Removing some old code which looked like it had to do with NACK handling but in reality did nothing.

BUG=webrtc:5762, webrtc:4690
R=stefan@webrtc.org
TBR=mflodman

Committed: https://crrev.com/cd6ae6652f075d9699c9f22795d15742ce1a7205
Cr-Commit-Position: refs/heads/master@{#12682}

[the sun, 2016-05-04 10:47:49]

solenberg@webrtc.org changed reviewers:
+ mflodman@webrtc.org, stefan@webrtc.org

[mflodman, 2016-05-06 08:15:56]

Code removal LG, but I'm not sure this is the right way to go. To me it seems
reasonable to require NACK to be configured, given it's enabled through call
setup and negotiation, and have ModuleRtpRtcpImpl::SendNACK not trigger a new
NACK in case it hasn't been enabled.

Fredrik, Stefan,
WDYT?

[stefan-webrtc, 2016-05-06 11:34:51]

lgtm 

On 2016/05/06 08:15:56, mflodman wrote:
> Code removal LG, but I'm not sure this is the right way to go. To me it seems
> reasonable to require NACK to be configured, given it's enabled through call
> setup and negotiation, and have ModuleRtpRtcpImpl::SendNACK not trigger a new
> NACK in case it hasn't been enabled.
> 
> Fredrik, Stefan,
> WDYT?

For video NACK is disabled by disabling it on the VCM, which then won't report
missing packets to the RTP module. I think that is enough from a video point of
view. Seems to be handled in a similar way for audio in channel.cc.

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc...

[the sun, 2016-05-10 07:58:25]

The CQ bit was checked by solenberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-10 07:58:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1946183002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1946183002/80001

[commit-bot: I haz the power, 2016-05-10 08:16:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-10 08:16:39]

Dry run: Try jobs failed on following builders:
  android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)

[the sun, 2016-05-11 10:38:31]

Description was changed from

==========
Removing some old code which looked like it had to do with NACK handling but in
reality did nothing.

BUG=webrtc:5762, webrtc:4690
==========

to

==========
Removing some old code which looked like it had to do with NACK handling but in
reality did nothing.

BUG=webrtc:5762, webrtc:4690
TBR=mflodman
==========

[the sun, 2016-05-11 10:38:50]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2016-05-11 10:38:50]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1946183002/#ps100001 (title:
"rebase")

[commit-bot: I haz the power, 2016-05-11 10:38:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1946183002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1946183002/100001

[commit-bot: I haz the power, 2016-05-11 10:46:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 10:46:04]

Try jobs failed on following builders:
  android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)

[the sun, 2016-05-11 11:05:18]

Description was changed from

==========
Removing some old code which looked like it had to do with NACK handling but in
reality did nothing.

BUG=webrtc:5762, webrtc:4690
TBR=mflodman
==========

to

==========
Removing some old code which looked like it had to do with NACK handling but in
reality did nothing.

BUG=webrtc:5762, webrtc:4690
R=stefan@webrtc.org
TBR=mflodman

Committed:
https://chromium.googlesource.com/external/webrtc/+/cd6ae6652f075d9699c9f2279...
==========

[the sun, 2016-05-11 11:05:20]

Committed patchset #6 (id:100001) manually as
cd6ae6652f075d9699c9f22795d15742ce1a7205 (presubmit successful).

[commit-bot: I haz the power, 2016-05-11 11:05:22]

Description was changed from

==========
Removing some old code which looked like it had to do with NACK handling but in
reality did nothing.

BUG=webrtc:5762, webrtc:4690
R=stefan@webrtc.org
TBR=mflodman

Committed:
https://chromium.googlesource.com/external/webrtc/+/cd6ae6652f075d9699c9f2279...
==========

to

==========
Removing some old code which looked like it had to do with NACK handling but in
reality did nothing.

BUG=webrtc:5762, webrtc:4690
R=stefan@webrtc.org
TBR=mflodman

Committed: https://crrev.com/cd6ae6652f075d9699c9f22795d15742ce1a7205
Cr-Commit-Position: refs/heads/master@{#12682}
==========

[mflodman, 2016-05-27 22:02:01]

lgtm