webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc - Issue 1946183002: Removing some old code which looked like it had to do with NACK handling but in reality did nothing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc

Issue 1946183002: Removing some old code which looked like it had to do with NACK handling but in reality did nothing. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc

diff --git a/webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc b/webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc

index a73d4edaf3d221d5c530e09237b4110556e8b9eb..9a7b9d3f7ecd5f1c03c089ba791c5b04d8decfc3 100644

--- a/webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc

+++ b/webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc

@@ -191,7 +191,6 @@ class RtpRtcpRtxNackTest : public ::testing::Test {

rtp_rtcp_module_->SetSSRC(kTestSsrc);

rtp_rtcp_module_->SetRTCPStatus(RtcpMode::kCompound);

- rtp_receiver_->SetNACKStatus(kNackRtcp);

rtp_rtcp_module_->SetStorePacketsStatus(true, 600);

EXPECT_EQ(0, rtp_rtcp_module_->SetSendingStatus(true));

rtp_rtcp_module_->SetSequenceNumber(kTestSequenceNumber);

« no previous file with comments | « webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h ('k') | webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.h » ('j') | no next file with comments »