webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h - Issue 1946183002: Removing some old code which looked like it had to do with NACK handling but in reality did nothing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h

Issue 1946183002: Removing some old code which looked like it had to do with NACK handling but in reality did nothing. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h

diff --git a/webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h b/webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h

index 4cbb0424281cd628bd2ed01e68b3780adc8a84e8..bf5e93692155edf19716b9a288d507ba0085fcbd 100644

--- a/webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h

+++ b/webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h

@@ -202,10 +202,6 @@ class MockRtpRtcp : public RtpRtcp {

MOCK_METHOD1(SetTMMBRStatus, void(const bool enable));

MOCK_METHOD1(OnBandwidthEstimateUpdate,

void(uint16_t bandWidthKbit));

- MOCK_CONST_METHOD0(NACK,

- NACKMethod());

- MOCK_METHOD2(SetNACKStatus,

- int32_t(const NACKMethod method, int oldestSequenceNumberToNack));

MOCK_CONST_METHOD0(SelectiveRetransmissions,

int());

MOCK_METHOD1(SetSelectiveRetransmissions,

« no previous file with comments | « webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h ('k') | webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc » ('j') | no next file with comments »