webrtc/video/rtp_stream_receiver.cc - Issue 1946183002: Removing some old code which looked like it had to do with NACK handling but in reality did nothing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/video/rtp_stream_receiver.cc

Issue 1946183002: Removing some old code which looked like it had to do with NACK handling but in reality did nothing. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/video/rtp_stream_receiver.cc

diff --git a/webrtc/video/rtp_stream_receiver.cc b/webrtc/video/rtp_stream_receiver.cc

index 29bd78152e5ba4eee686b72d5145ce08a251b668..98b46831c53894ae655928156babf8120a45fff7 100644

--- a/webrtc/video/rtp_stream_receiver.cc

+++ b/webrtc/video/rtp_stream_receiver.cc

@@ -132,11 +132,8 @@ RtpStreamReceiver::RtpStreamReceiver(

}

static const int kMaxPacketAgeToNack = 450;

- NACKMethod nack_method =

- config.rtp.nack.rtp_history_ms > 0 ? kNackRtcp : kNackOff;

- const int max_reordering_threshold = (nack_method == kNackRtcp)

+ const int max_reordering_threshold = (config.rtp.nack.rtp_history_ms > 0)

? kMaxPacketAgeToNack : kDefaultMaxReorderingThreshold;

- rtp_receiver_->SetNACKStatus(nack_method);

rtp_receive_statistics_->SetMaxReorderingThreshold(max_reordering_threshold);

// TODO(pbos): Support multiple RTX, per video payload.

« no previous file with comments | « webrtc/modules/video_coding/test/rtp_player.cc ('k') | webrtc/voice_engine/channel.cc » ('j') | no next file with comments »