webrtc/voice_engine/channel.cc - Issue 1946183002: Removing some old code which looked like it had to do with NACK handling but in reality did nothing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/voice_engine/channel.cc

Issue 1946183002: Removing some old code which looked like it had to do with NACK handling but in reality did nothing. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/voice_engine/channel.cc

diff --git a/webrtc/voice_engine/channel.cc b/webrtc/voice_engine/channel.cc

index a6c0c8d050538c45774ddee0883e6dad4a72450e..37b02702dc1539bb8a5f479b4ab14ba8a45ba9d8 100644

--- a/webrtc/voice_engine/channel.cc

+++ b/webrtc/voice_engine/channel.cc

@@ -2914,7 +2914,6 @@ void Channel::SetNACKStatus(bool enable, int maxNumberOfPackets) {

if (!pacing_enabled_)

_rtpRtcpModule->SetStorePacketsStatus(enable, maxNumberOfPackets);

rtp_receive_statistics_->SetMaxReorderingThreshold(maxNumberOfPackets);

- rtp_receiver_->SetNACKStatus(enable ? kNackRtcp : kNackOff);

if (enable)

audio_coding_->EnableNack(maxNumberOfPackets);

else

« no previous file with comments | « webrtc/video/rtp_stream_receiver.cc ('k') | no next file » | no next file with comments »