Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Side by Side Diff: webrtc/modules/video_coding/test/rtp_player.cc

Issue 1946183002: Removing some old code which looked like it had to do with NACK handling but in reality did nothing. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 RtpRtcp::Configuration configuration; 221 RtpRtcp::Configuration configuration;
222 configuration.clock = clock; 222 configuration.clock = clock;
223 configuration.audio = false; 223 configuration.audio = false;
224 handler->rtp_module_.reset(RtpReceiver::CreateVideoReceiver( 224 handler->rtp_module_.reset(RtpReceiver::CreateVideoReceiver(
225 configuration.clock, handler->payload_sink_.get(), NULL, 225 configuration.clock, handler->payload_sink_.get(), NULL,
226 handler->rtp_payload_registry_.get())); 226 handler->rtp_payload_registry_.get()));
227 if (handler->rtp_module_.get() == NULL) { 227 if (handler->rtp_module_.get() == NULL) {
228 return -1; 228 return -1;
229 } 229 }
230 230
231 handler->rtp_module_->SetNACKStatus(kNackOff);
232 handler->rtp_header_parser_->RegisterRtpHeaderExtension( 231 handler->rtp_header_parser_->RegisterRtpHeaderExtension(
233 kRtpExtensionTransmissionTimeOffset, 232 kRtpExtensionTransmissionTimeOffset,
234 kDefaultTransmissionTimeOffsetExtensionId); 233 kDefaultTransmissionTimeOffsetExtensionId);
235 234
236 for (PayloadTypesIterator it = payload_types_.begin(); 235 for (PayloadTypesIterator it = payload_types_.begin();
237 it != payload_types_.end(); ++it) { 236 it != payload_types_.end(); ++it) {
238 VideoCodec codec; 237 VideoCodec codec;
239 memset(&codec, 0, sizeof(codec)); 238 memset(&codec, 0, sizeof(codec));
240 strncpy(codec.plName, it->name().c_str(), sizeof(codec.plName) - 1); 239 strncpy(codec.plName, it->name().c_str(), sizeof(codec.plName) - 1);
241 codec.plType = it->payload_type(); 240 codec.plType = it->payload_type();
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
484 } 483 }
485 } 484 }
486 485
487 std::unique_ptr<RtpPlayerImpl> impl( 486 std::unique_ptr<RtpPlayerImpl> impl(
488 new RtpPlayerImpl(payload_sink_factory, payload_types, clock, 487 new RtpPlayerImpl(payload_sink_factory, payload_types, clock,
489 &packet_source, loss_rate, rtt_ms, reordering)); 488 &packet_source, loss_rate, rtt_ms, reordering));
490 return impl.release(); 489 return impl.release();
491 } 490 }
492 } // namespace rtpplayer 491 } // namespace rtpplayer
493 } // namespace webrtc 492 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/test/testAPI/test_api_video.cc ('k') | webrtc/video/rtp_stream_receiver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698