Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: webrtc/modules/rtp_rtcp/include/rtp_receiver.h

Issue 1946183002: Removing some old code which looked like it had to do with NACK handling but in reality did nothing. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 68
69 // Parses the media specific parts of an RTP packet and updates the receiver 69 // Parses the media specific parts of an RTP packet and updates the receiver
70 // state. This for instance means that any changes in SSRC and payload type is 70 // state. This for instance means that any changes in SSRC and payload type is
71 // detected and acted upon. 71 // detected and acted upon.
72 virtual bool IncomingRtpPacket(const RTPHeader& rtp_header, 72 virtual bool IncomingRtpPacket(const RTPHeader& rtp_header,
73 const uint8_t* payload, 73 const uint8_t* payload,
74 size_t payload_length, 74 size_t payload_length,
75 PayloadUnion payload_specific, 75 PayloadUnion payload_specific,
76 bool in_order) = 0; 76 bool in_order) = 0;
77 77
78 // Returns the currently configured NACK method.
79 virtual NACKMethod NACK() const = 0;
80
81 // Turn negative acknowledgement (NACK) requests on/off.
82 virtual void SetNACKStatus(const NACKMethod method) = 0;
83
84 // Gets the last received timestamp. Returns true if a packet has been 78 // Gets the last received timestamp. Returns true if a packet has been
85 // received, false otherwise. 79 // received, false otherwise.
86 virtual bool Timestamp(uint32_t* timestamp) const = 0; 80 virtual bool Timestamp(uint32_t* timestamp) const = 0;
87 // Gets the time in milliseconds when the last timestamp was received. 81 // Gets the time in milliseconds when the last timestamp was received.
88 // Returns true if a packet has been received, false otherwise. 82 // Returns true if a packet has been received, false otherwise.
89 virtual bool LastReceivedTimeMs(int64_t* receive_time_ms) const = 0; 83 virtual bool LastReceivedTimeMs(int64_t* receive_time_ms) const = 0;
90 84
91 // Returns the remote SSRC of the currently received RTP stream. 85 // Returns the remote SSRC of the currently received RTP stream.
92 virtual uint32_t SSRC() const = 0; 86 virtual uint32_t SSRC() const = 0;
93 87
94 // Returns the current remote CSRCs. 88 // Returns the current remote CSRCs.
95 virtual int32_t CSRCs(uint32_t array_of_csrc[kRtpCsrcSize]) const = 0; 89 virtual int32_t CSRCs(uint32_t array_of_csrc[kRtpCsrcSize]) const = 0;
96 90
97 // Returns the current energy of the RTP stream received. 91 // Returns the current energy of the RTP stream received.
98 virtual int32_t Energy(uint8_t array_of_energy[kRtpCsrcSize]) const = 0; 92 virtual int32_t Energy(uint8_t array_of_energy[kRtpCsrcSize]) const = 0;
99 }; 93 };
100 } // namespace webrtc 94 } // namespace webrtc
101 95
102 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RECEIVER_H_ 96 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RECEIVER_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698