webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc - Issue 1946183002: Removing some old code which looked like it had to do with NACK handling but in reality did nothing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc

Issue 1946183002: Removing some old code which looked like it had to do with NACK handling but in reality did nothing. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc

diff --git a/webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc b/webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc

index ea2d98bc3a9154c9564e49ca6524a9299d8d9025..89c9cbebeba43ec38673db1eca22a7a5c59ba0b9 100644

--- a/webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc

+++ b/webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc

@@ -152,10 +152,6 @@ TEST_F(RtpRtcpAPITest, RTCP) {

EXPECT_TRUE(module_->TMMBR());

module_->SetTMMBRStatus(false);

EXPECT_FALSE(module_->TMMBR());

- EXPECT_EQ(kNackOff, rtp_receiver_->NACK());

- rtp_receiver_->SetNACKStatus(kNackRtcp);

- EXPECT_EQ(kNackRtcp, rtp_receiver_->NACK());

}

TEST_F(RtpRtcpAPITest, RtxSender) {

« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc ('k') | webrtc/modules/rtp_rtcp/test/testAPI/test_api_video.cc » ('j') | no next file with comments »