Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: webrtc/modules/rtp_rtcp/test/testAPI/test_api_video.cc

Issue 1946183002: Removing some old code which looked like it had to do with NACK handling but in reality did nothing. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 configuration.audio = false; 49 configuration.audio = false;
50 configuration.clock = &fake_clock; 50 configuration.clock = &fake_clock;
51 configuration.outgoing_transport = transport_; 51 configuration.outgoing_transport = transport_;
52 52
53 video_module_ = RtpRtcp::CreateRtpRtcp(configuration); 53 video_module_ = RtpRtcp::CreateRtpRtcp(configuration);
54 rtp_receiver_.reset(RtpReceiver::CreateVideoReceiver( 54 rtp_receiver_.reset(RtpReceiver::CreateVideoReceiver(
55 &fake_clock, receiver_, NULL, &rtp_payload_registry_)); 55 &fake_clock, receiver_, NULL, &rtp_payload_registry_));
56 56
57 video_module_->SetRTCPStatus(RtcpMode::kCompound); 57 video_module_->SetRTCPStatus(RtcpMode::kCompound);
58 video_module_->SetSSRC(test_ssrc_); 58 video_module_->SetSSRC(test_ssrc_);
59 rtp_receiver_->SetNACKStatus(kNackRtcp);
60 video_module_->SetStorePacketsStatus(true, 600); 59 video_module_->SetStorePacketsStatus(true, 600);
61 EXPECT_EQ(0, video_module_->SetSendingStatus(true)); 60 EXPECT_EQ(0, video_module_->SetSendingStatus(true));
62 61
63 transport_->SetSendModule(video_module_, &rtp_payload_registry_, 62 transport_->SetSendModule(video_module_, &rtp_payload_registry_,
64 rtp_receiver_.get(), receive_statistics_.get()); 63 rtp_receiver_.get(), receive_statistics_.get());
65 64
66 VideoCodec video_codec; 65 VideoCodec video_codec;
67 memset(&video_codec, 0, sizeof(video_codec)); 66 memset(&video_codec, 0, sizeof(video_codec));
68 video_codec.plType = 123; 67 video_codec.plType = 123;
69 memcpy(video_codec.plName, "I420", 5); 68 memcpy(video_codec.plName, "I420", 5);
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 payload_specific, true)); 182 payload_specific, true));
184 EXPECT_EQ(0u, receiver_->payload_size()); 183 EXPECT_EQ(0u, receiver_->payload_size());
185 EXPECT_EQ(payload_length, receiver_->rtp_header().header.paddingLength); 184 EXPECT_EQ(payload_length, receiver_->rtp_header().header.paddingLength);
186 } 185 }
187 timestamp += 3000; 186 timestamp += 3000;
188 fake_clock.AdvanceTimeMilliseconds(33); 187 fake_clock.AdvanceTimeMilliseconds(33);
189 } 188 }
190 } 189 }
191 190
192 } // namespace webrtc 191 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc ('k') | webrtc/modules/video_coding/test/rtp_player.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698