Enable -Winconsistent-missing-override flag.

Enable -Winconsistent-missing-override flag.

The problem with gmock is worked around by commenting out any other override declarations in classes using gmock.

NOPRESUBMIT=True
BUG=webrtc:3970
Committed: https://crrev.com/ef8b61e11062295365f11b9942f18a08a8b3ec60
Cr-Commit-Position: refs/heads/master@{#12563}

[nisse-webrtc, 2016-04-25 13:55:20]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-25 13:55:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921653002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921653002/1

[commit-bot: I haz the power, 2016-04-25 14:12:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 14:12:34]

Dry run: Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/5061)

[nisse-webrtc, 2016-04-27 12:40:07]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 12:40:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921653002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921653002/20001

[commit-bot: I haz the power, 2016-04-27 12:51:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 12:51:48]

Dry run: Try jobs failed on following builders:
  ios_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/13217)

[nisse-webrtc, 2016-04-27 12:52:31]

Description was changed from

==========
Enable -Winconsistent-missing-override flag.

BUG=
==========

to

==========
Enable -Winconsistent-missing-override flag.

The problem with gmock is worked-around by commenting out any other override
declarations in clases using gmock.

BUG=webrtc:5426
==========

[nisse-webrtc, 2016-04-27 12:58:29]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 12:58:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921653002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921653002/40001

[nisse-webrtc, 2016-04-27 13:04:30]

Description was changed from

==========
Enable -Winconsistent-missing-override flag.

The problem with gmock is worked-around by commenting out any other override
declarations in clases using gmock.

BUG=webrtc:5426
==========

to

==========
Enable -Winconsistent-missing-override flag.

The problem with gmock is worked around by commenting out any other override
declarations in classes using gmock.

BUG=webrtc:5426
==========

[nisse-webrtc, 2016-04-27 13:05:20]

Description was changed from

==========
Enable -Winconsistent-missing-override flag.

The problem with gmock is worked around by commenting out any other override
declarations in classes using gmock.

BUG=webrtc:5426
==========

to

==========
Enable -Winconsistent-missing-override flag.

The problem with gmock is worked around by commenting out any other override
declarations in classes using gmock.

BUG=webrtc:3970
==========

[nisse-webrtc, 2016-04-27 13:05:58]

nisse@webrtc.org changed reviewers:
+ kjellander@webrtc.org, mflodman@webrtc.org

[commit-bot: I haz the power, 2016-04-27 14:04:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 14:04:46]

Dry run: Try jobs failed on following builders:
  win_baremetal on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/10851)

[kjellander_webrtc, 2016-04-27 14:11:35]

all sources look good, but please add the warning to the GN build as well (see
comment)

https://codereview.webrtc.org/1921653002/diff/40001/webrtc/build/common.gypi
File webrtc/build/common.gypi (right):

https://codereview.webrtc.org/1921653002/diff/40001/webrtc/build/common.gypi#...
webrtc/build/common.gypi:316: '-Winconsistent-missing-override',
Please add this warning to
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc...
as well.
I noticed -Wimplicit-fallthrough was missing in there as well, so I created
https://codereview.webrtc.org/1928543002/ for that.

[nisse-webrtc, 2016-04-29 08:12:42]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 08:12:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921653002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921653002/60001

[commit-bot: I haz the power, 2016-04-29 08:20:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 08:20:01]

Dry run: Try jobs failed on following builders:
  android_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/12924)

[nisse-webrtc, 2016-04-29 08:35:02]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 08:35:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921653002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921653002/80001

[commit-bot: I haz the power, 2016-04-29 09:32:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 09:32:19]

Dry run: Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/5164)

[nisse-webrtc, 2016-04-29 09:51:37]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 09:51:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921653002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921653002/80001

[commit-bot: I haz the power, 2016-04-29 09:54:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 09:54:53]

Dry run: Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/5166)

[nisse-webrtc, 2016-04-29 11:46:52]

Looks all green now, except for an exception in presubmit which I don't quite
undestand.

[kjellander_webrtc, 2016-04-29 12:16:28]

On 2016/04/29 11:46:52, nisse-webrtc wrote:
> Looks all green now, except for an exception in presubmit which I don't quite
> undestand.

lgtm, bypass the presubmit bot by manually committing or adding NOPRESUBMIT=True
to the CL description.
I filed https://bugs.chromium.org/p/webrtc/issues/detail?id=5842 for the error.

[mflodman, 2016-04-29 12:44:11]

Agree in general and looking at some samples, after talking to nisse, and
trusting kjellanders review, LGTM

[nisse-webrtc, 2016-04-29 13:08:32]

Description was changed from

==========
Enable -Winconsistent-missing-override flag.

The problem with gmock is worked around by commenting out any other override
declarations in classes using gmock.

BUG=webrtc:3970
==========

to

==========
Enable -Winconsistent-missing-override flag.

The problem with gmock is worked around by commenting out any other override
declarations in classes using gmock.

NOPRESUBMIT=True
BUG=webrtc:3970
==========

[nisse-webrtc, 2016-04-29 13:08:42]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-04-29 13:08:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921653002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921653002/80001

[commit-bot: I haz the power, 2016-04-29 13:09:19]

Description was changed from

==========
Enable -Winconsistent-missing-override flag.

The problem with gmock is worked around by commenting out any other override
declarations in classes using gmock.

NOPRESUBMIT=True
BUG=webrtc:3970
==========

to

==========
Enable -Winconsistent-missing-override flag.

The problem with gmock is worked around by commenting out any other override
declarations in classes using gmock.

NOPRESUBMIT=True
BUG=webrtc:3970
==========

[commit-bot: I haz the power, 2016-04-29 13:09:20]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-01 22:01:56]

Description was changed from

==========
Enable -Winconsistent-missing-override flag.

The problem with gmock is worked around by commenting out any other override
declarations in classes using gmock.

NOPRESUBMIT=True
BUG=webrtc:3970
==========

to

==========
Enable -Winconsistent-missing-override flag.

The problem with gmock is worked around by commenting out any other override
declarations in classes using gmock.

NOPRESUBMIT=True
BUG=webrtc:3970

Committed: https://crrev.com/ef8b61e11062295365f11b9942f18a08a8b3ec60
Cr-Commit-Position: refs/heads/master@{#12563}
==========

[commit-bot: I haz the power, 2016-05-01 22:01:58]

Patchset 5 (id:??) landed as
https://crrev.com/ef8b61e11062295365f11b9942f18a08a8b3ec60
Cr-Commit-Position: refs/heads/master@{#12563}

[ivoc, 2016-05-03 14:42:59]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.webrtc.org/1944743002/ by ivoc@webrtc.org.

The reason for reverting is: This CL breaks the google3 import (but not the
import bot)..

[ivoc, 2016-05-04 07:40:24]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.webrtc.org/1946133002/ by ivoc@webrtc.org.

The reason for reverting is: This CL breaks the google3 import (but not the
import bot).
.