Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: webrtc/base/callback_unittest.cc

Issue 1921653002: Enable -Winconsistent-missing-override flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/webrtcsession_unittest.cc ('k') | webrtc/base/fakesslidentity.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 16 matching lines...) Expand all
27 int a() { return 24; } 27 int a() { return 24; }
28 int b(int x) const { return x * x; } 28 int b(int x) const { return x * x; }
29 }; 29 };
30 30
31 class RefCountedBindTester : public RefCountInterface { 31 class RefCountedBindTester : public RefCountInterface {
32 public: 32 public:
33 RefCountedBindTester() : count_(0) {} 33 RefCountedBindTester() : count_(0) {}
34 int AddRef() const override { 34 int AddRef() const override {
35 return ++count_; 35 return ++count_;
36 } 36 }
37 int Release() const { 37 int Release() const override {
38 return --count_; 38 return --count_;
39 } 39 }
40 int RefCount() const { return count_; } 40 int RefCount() const { return count_; }
41 41
42 private: 42 private:
43 mutable int count_; 43 mutable int count_;
44 }; 44 };
45 45
46 } // namespace 46 } // namespace
47 47
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 Callback0<void> cb = KeepRefUntilDone(t_scoped_ref); 131 Callback0<void> cb = KeepRefUntilDone(t_scoped_ref);
132 t_scoped_ref = nullptr; 132 t_scoped_ref = nullptr;
133 EXPECT_EQ(1, t.RefCount()); 133 EXPECT_EQ(1, t.RefCount());
134 cb(); 134 cb();
135 EXPECT_EQ(1, t.RefCount()); 135 EXPECT_EQ(1, t.RefCount());
136 } 136 }
137 EXPECT_EQ(0, t.RefCount()); 137 EXPECT_EQ(0, t.RefCount());
138 } 138 }
139 139
140 } // namespace rtc 140 } // namespace rtc
OLDNEW
« no previous file with comments | « webrtc/api/webrtcsession_unittest.cc ('k') | webrtc/base/fakesslidentity.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698