Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: webrtc/base/sslstreamadapter_unittest.cc

Issue 1921653002: Enable -Winconsistent-missing-override flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/rtccertificategenerator_unittest.cc ('k') | webrtc/build/common.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/sslstreamadapter_unittest.cc
diff --git a/webrtc/base/sslstreamadapter_unittest.cc b/webrtc/base/sslstreamadapter_unittest.cc
index ac9fef9f248ad15ca09c83a68af58270a602daf2..dc62ac081b772bffb9fcb04eafb00a8ceba0c93a 100644
--- a/webrtc/base/sslstreamadapter_unittest.cc
+++ b/webrtc/base/sslstreamadapter_unittest.cc
@@ -562,7 +562,7 @@ class SSLStreamAdapterTestTLS
}
// Test data transfer for TLS
- virtual void TestTransfer(int size) {
+ void TestTransfer(int size) override {
LOG(LS_INFO) << "Starting transfer test with " << size << " bytes";
// Create some dummy data to send.
size_t received;
@@ -591,7 +591,7 @@ class SSLStreamAdapterTestTLS
recv_stream_.GetBuffer(), size));
}
- void WriteData() {
+ void WriteData() override {
size_t position, tosend, size;
rtc::StreamResult rv;
size_t sent;
@@ -627,7 +627,7 @@ class SSLStreamAdapterTestTLS
}
};
- virtual void ReadData(rtc::StreamInterface *stream) {
+ void ReadData(rtc::StreamInterface *stream) override {
char buffer[1600];
size_t bread;
int err2;
@@ -691,7 +691,7 @@ class SSLStreamAdapterTestDTLS
new SSLDummyStreamDTLS(this, "s2c", &server_buffer_, &client_buffer_);
}
- virtual void WriteData() {
+ void WriteData() override {
unsigned char *packet = new unsigned char[1600];
while (sent_ < count_) {
@@ -720,7 +720,7 @@ class SSLStreamAdapterTestDTLS
delete [] packet;
}
- virtual void ReadData(rtc::StreamInterface *stream) {
+ void ReadData(rtc::StreamInterface *stream) override {
unsigned char buffer[2000];
size_t bread;
int err2;
@@ -756,7 +756,7 @@ class SSLStreamAdapterTestDTLS
}
}
- virtual void TestTransfer(int count) {
+ void TestTransfer(int count) override {
count_ = count;
WriteData();
« no previous file with comments | « webrtc/base/rtccertificategenerator_unittest.cc ('k') | webrtc/build/common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698