Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: webrtc/p2p/base/port_unittest.cc

Issue 1921653002: Enable -Winconsistent-missing-override flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/p2p/base/faketransportcontroller.h ('k') | webrtc/test/mock_voice_engine.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 947 matching lines...) Expand 10 before | Expand all | Expand 10 after
958 958
959 void set_next_udp_socket(AsyncPacketSocket* next_udp_socket) { 959 void set_next_udp_socket(AsyncPacketSocket* next_udp_socket) {
960 next_udp_socket_ = next_udp_socket; 960 next_udp_socket_ = next_udp_socket;
961 } 961 }
962 void set_next_server_tcp_socket(AsyncPacketSocket* next_server_tcp_socket) { 962 void set_next_server_tcp_socket(AsyncPacketSocket* next_server_tcp_socket) {
963 next_server_tcp_socket_ = next_server_tcp_socket; 963 next_server_tcp_socket_ = next_server_tcp_socket;
964 } 964 }
965 void set_next_client_tcp_socket(AsyncPacketSocket* next_client_tcp_socket) { 965 void set_next_client_tcp_socket(AsyncPacketSocket* next_client_tcp_socket) {
966 next_client_tcp_socket_ = next_client_tcp_socket; 966 next_client_tcp_socket_ = next_client_tcp_socket;
967 } 967 }
968 rtc::AsyncResolverInterface* CreateAsyncResolver() { 968 rtc::AsyncResolverInterface* CreateAsyncResolver() override {
969 return NULL; 969 return NULL;
970 } 970 }
971 971
972 private: 972 private:
973 AsyncPacketSocket* next_udp_socket_; 973 AsyncPacketSocket* next_udp_socket_;
974 AsyncPacketSocket* next_server_tcp_socket_; 974 AsyncPacketSocket* next_server_tcp_socket_;
975 AsyncPacketSocket* next_client_tcp_socket_; 975 AsyncPacketSocket* next_client_tcp_socket_;
976 }; 976 };
977 977
978 class FakeAsyncPacketSocket : public AsyncPacketSocket { 978 class FakeAsyncPacketSocket : public AsyncPacketSocket {
(...skipping 1600 matching lines...) Expand 10 before | Expand all | Expand 10 after
2579 std::unique_ptr<Port> tcp_port(CreateTcpPort(kLocalAddr1)); 2579 std::unique_ptr<Port> tcp_port(CreateTcpPort(kLocalAddr1));
2580 EXPECT_TRUE(tcp_port->SupportsProtocol(TCP_PROTOCOL_NAME)); 2580 EXPECT_TRUE(tcp_port->SupportsProtocol(TCP_PROTOCOL_NAME));
2581 EXPECT_TRUE(tcp_port->SupportsProtocol(SSLTCP_PROTOCOL_NAME)); 2581 EXPECT_TRUE(tcp_port->SupportsProtocol(SSLTCP_PROTOCOL_NAME));
2582 EXPECT_FALSE(tcp_port->SupportsProtocol(UDP_PROTOCOL_NAME)); 2582 EXPECT_FALSE(tcp_port->SupportsProtocol(UDP_PROTOCOL_NAME));
2583 2583
2584 std::unique_ptr<Port> turn_port( 2584 std::unique_ptr<Port> turn_port(
2585 CreateTurnPort(kLocalAddr1, nat_socket_factory1(), PROTO_UDP, PROTO_UDP)); 2585 CreateTurnPort(kLocalAddr1, nat_socket_factory1(), PROTO_UDP, PROTO_UDP));
2586 EXPECT_TRUE(turn_port->SupportsProtocol(UDP_PROTOCOL_NAME)); 2586 EXPECT_TRUE(turn_port->SupportsProtocol(UDP_PROTOCOL_NAME));
2587 EXPECT_FALSE(turn_port->SupportsProtocol(TCP_PROTOCOL_NAME)); 2587 EXPECT_FALSE(turn_port->SupportsProtocol(TCP_PROTOCOL_NAME));
2588 } 2588 }
OLDNEW
« no previous file with comments | « webrtc/p2p/base/faketransportcontroller.h ('k') | webrtc/test/mock_voice_engine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698