Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: webrtc/build/common.gypi

Issue 1921653002: Enable -Winconsistent-missing-override flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/sslstreamadapter_unittest.cc ('k') | webrtc/call/call_perf_tests.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 # This file contains common settings for building WebRTC components. 9 # This file contains common settings for building WebRTC components.
10 10
(...skipping 295 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 'cflags_cc': [ 306 'cflags_cc': [
307 '-Wnon-virtual-dtor', 307 '-Wnon-virtual-dtor',
308 # This is enabled for clang; enable for gcc as well. 308 # This is enabled for clang; enable for gcc as well.
309 '-Woverloaded-virtual', 309 '-Woverloaded-virtual',
310 ], 310 ],
311 }], 311 }],
312 ['clang==1', { 312 ['clang==1', {
313 'cflags': [ 313 'cflags': [
314 '-Wimplicit-fallthrough', 314 '-Wimplicit-fallthrough',
315 '-Wthread-safety', 315 '-Wthread-safety',
316 '-Winconsistent-missing-override',
kjellander_webrtc 2016/04/27 14:11:35 Please add this warning to https://code.google.com
316 ], 317 ],
317 }], 318 }],
318 ], 319 ],
319 }], 320 }],
320 ['target_arch=="arm64"', { 321 ['target_arch=="arm64"', {
321 'defines': [ 322 'defines': [
322 'WEBRTC_ARCH_ARM64', 323 'WEBRTC_ARCH_ARM64',
323 'WEBRTC_HAS_NEON', 324 'WEBRTC_HAS_NEON',
324 ], 325 ],
325 }], 326 }],
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
502 # For access to standard POSIXish features, use WEBRTC_POSIX instead 503 # For access to standard POSIXish features, use WEBRTC_POSIX instead
503 # of a more specific macro. 504 # of a more specific macro.
504 'defines': [ 505 'defines': [
505 'WEBRTC_POSIX', 506 'WEBRTC_POSIX',
506 ], 507 ],
507 }], 508 }],
508 ], 509 ],
509 }, 510 },
510 }, # target_defaults 511 }, # target_defaults
511 } 512 }
OLDNEW
« no previous file with comments | « webrtc/base/sslstreamadapter_unittest.cc ('k') | webrtc/call/call_perf_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698