Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: webrtc/common_video/i420_buffer_pool.cc

Issue 1921653002: Enable -Winconsistent-missing-override flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/call/call_perf_tests.cc ('k') | webrtc/media/base/fakemediaengine.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 12 matching lines...) Expand all
23 23
24 private: 24 private:
25 ~PooledI420Buffer() override {} 25 ~PooledI420Buffer() override {}
26 26
27 int width() const override { return buffer_->width(); } 27 int width() const override { return buffer_->width(); }
28 int height() const override { return buffer_->height(); } 28 int height() const override { return buffer_->height(); }
29 const uint8_t* DataY() const override { return buffer_->DataY(); } 29 const uint8_t* DataY() const override { return buffer_->DataY(); }
30 const uint8_t* DataU() const override { return buffer_->DataU(); } 30 const uint8_t* DataU() const override { return buffer_->DataU(); }
31 const uint8_t* DataV() const override { return buffer_->DataV(); } 31 const uint8_t* DataV() const override { return buffer_->DataV(); }
32 32
33 bool IsMutable() { return HasOneRef(); } 33 bool IsMutable() override { return HasOneRef(); }
34 // Make the IsMutable() check here instead of in |buffer_|, because the pool 34 // Make the IsMutable() check here instead of in |buffer_|, because the pool
35 // also has a reference to |buffer_|. 35 // also has a reference to |buffer_|.
36 uint8_t* MutableDataY() override { 36 uint8_t* MutableDataY() override {
37 RTC_DCHECK(IsMutable()); 37 RTC_DCHECK(IsMutable());
38 return const_cast<uint8_t*>(buffer_->DataY()); 38 return const_cast<uint8_t*>(buffer_->DataY());
39 } 39 }
40 uint8_t* MutableDataU() override { 40 uint8_t* MutableDataU() override {
41 RTC_DCHECK(IsMutable()); 41 RTC_DCHECK(IsMutable());
42 return const_cast<uint8_t*>(buffer_->DataU()); 42 return const_cast<uint8_t*>(buffer_->DataU());
43 } 43 }
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 // Allocate new buffer. 96 // Allocate new buffer.
97 rtc::scoped_refptr<I420Buffer> buffer = new rtc::RefCountedObject<I420Buffer>( 97 rtc::scoped_refptr<I420Buffer> buffer = new rtc::RefCountedObject<I420Buffer>(
98 width, height); 98 width, height);
99 if (zero_initialize_) 99 if (zero_initialize_)
100 buffer->InitializeData(); 100 buffer->InitializeData();
101 buffers_.push_back(buffer); 101 buffers_.push_back(buffer);
102 return new rtc::RefCountedObject<PooledI420Buffer>(buffers_.back()); 102 return new rtc::RefCountedObject<PooledI420Buffer>(buffers_.back());
103 } 103 }
104 104
105 } // namespace webrtc 105 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/call/call_perf_tests.cc ('k') | webrtc/media/base/fakemediaengine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698