Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Side by Side Diff: webrtc/modules/utility/source/file_recorder_impl.h

Issue 1921653002: Enable -Winconsistent-missing-override flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 27 matching lines...) Expand all
38 38
39 class CriticalSectionWrapper; 39 class CriticalSectionWrapper;
40 40
41 class FileRecorderImpl : public FileRecorder 41 class FileRecorderImpl : public FileRecorder
42 { 42 {
43 public: 43 public:
44 FileRecorderImpl(uint32_t instanceID, FileFormats fileFormat); 44 FileRecorderImpl(uint32_t instanceID, FileFormats fileFormat);
45 virtual ~FileRecorderImpl(); 45 virtual ~FileRecorderImpl();
46 46
47 // FileRecorder functions. 47 // FileRecorder functions.
48 virtual int32_t RegisterModuleFileCallback(FileCallback* callback); 48 int32_t RegisterModuleFileCallback(FileCallback* callback) override;
49 virtual FileFormats RecordingFileFormat() const; 49 FileFormats RecordingFileFormat() const override;
50 virtual int32_t StartRecordingAudioFile( 50 int32_t StartRecordingAudioFile(
51 const char* fileName, 51 const char* fileName,
52 const CodecInst& codecInst, 52 const CodecInst& codecInst,
53 uint32_t notificationTimeMs) override; 53 uint32_t notificationTimeMs) override;
54 virtual int32_t StartRecordingAudioFile( 54 int32_t StartRecordingAudioFile(
55 OutStream& destStream, 55 OutStream& destStream,
56 const CodecInst& codecInst, 56 const CodecInst& codecInst,
57 uint32_t notificationTimeMs) override; 57 uint32_t notificationTimeMs) override;
58 virtual int32_t StopRecording(); 58 int32_t StopRecording() override;
59 virtual bool IsRecording() const; 59 bool IsRecording() const override;
60 virtual int32_t codec_info(CodecInst& codecInst) const; 60 int32_t codec_info(CodecInst& codecInst) const override;
61 virtual int32_t RecordAudioToFile( 61 int32_t RecordAudioToFile(
62 const AudioFrame& frame, 62 const AudioFrame& frame,
63 const TickTime* playoutTS = NULL); 63 const TickTime* playoutTS = NULL) override;
64 virtual int32_t StartRecordingVideoFile( 64 int32_t StartRecordingVideoFile(
65 const char* fileName, 65 const char* fileName,
66 const CodecInst& audioCodecInst, 66 const CodecInst& audioCodecInst,
67 const VideoCodec& videoCodecInst, 67 const VideoCodec& videoCodecInst,
68 bool videoOnly = false) override 68 bool videoOnly = false) override
69 { 69 {
70 return -1; 70 return -1;
71 } 71 }
72 virtual int32_t RecordVideoToFile(const VideoFrame& videoFrame) { 72 int32_t RecordVideoToFile(const VideoFrame& videoFrame) override {
73 return -1; 73 return -1;
74 } 74 }
75 75
76 protected: 76 protected:
77 int32_t WriteEncodedAudioData(const int8_t* audioBuffer, 77 int32_t WriteEncodedAudioData(const int8_t* audioBuffer,
78 size_t bufferLength); 78 size_t bufferLength);
79 79
80 int32_t SetUpAudioEncoder(); 80 int32_t SetUpAudioEncoder();
81 81
82 uint32_t _instanceID; 82 uint32_t _instanceID;
83 FileFormats _fileFormat; 83 FileFormats _fileFormat;
84 MediaFile* _moduleFile; 84 MediaFile* _moduleFile;
85 85
86 private: 86 private:
87 CodecInst codec_info_; 87 CodecInst codec_info_;
88 int8_t _audioBuffer[MAX_AUDIO_BUFFER_IN_BYTES]; 88 int8_t _audioBuffer[MAX_AUDIO_BUFFER_IN_BYTES];
89 AudioCoder _audioEncoder; 89 AudioCoder _audioEncoder;
90 Resampler _audioResampler; 90 Resampler _audioResampler;
91 }; 91 };
92 } // namespace webrtc 92 } // namespace webrtc
93 #endif // WEBRTC_MODULES_UTILITY_SOURCE_FILE_RECORDER_IMPL_H_ 93 #endif // WEBRTC_MODULES_UTILITY_SOURCE_FILE_RECORDER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698