webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h - Issue 1921653002: Enable -Winconsistent-missing-override flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h

Issue 1921653002: Enable -Winconsistent-missing-override flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h

index 1511afb955130e16010e4927c22178142a6bf15e..0630adbac244a4d48929b962add8c004d110a3f0 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h

@@ -50,7 +50,7 @@ class ReceiverReport : public RtcpPacket {

static const size_t kRrBaseLength = 4;

static const size_t kMaxNumberOfReportBlocks = 0x1F;

- size_t BlockLength() const {

+ size_t BlockLength() const override {

return kHeaderLength + kRrBaseLength +

report_blocks_.size() * ReportBlock::kLength;

}