webrtc/common_video/i420_buffer_pool.cc - Issue 1921653002: Enable -Winconsistent-missing-override flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/common_video/i420_buffer_pool.cc

Issue 1921653002: Enable -Winconsistent-missing-override flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/common_video/i420_buffer_pool.cc

diff --git a/webrtc/common_video/i420_buffer_pool.cc b/webrtc/common_video/i420_buffer_pool.cc

index c382e9337835665d24e04d48778f72a1f55a0575..8896260fc0ecf4500e195757ac6b0390dee948ba 100644

--- a/webrtc/common_video/i420_buffer_pool.cc

+++ b/webrtc/common_video/i420_buffer_pool.cc

@@ -30,7 +30,7 @@ class PooledI420Buffer : public webrtc::VideoFrameBuffer {

const uint8_t* DataU() const override { return buffer_->DataU(); }

const uint8_t* DataV() const override { return buffer_->DataV(); }

- bool IsMutable() { return HasOneRef(); }

+ bool IsMutable() override { return HasOneRef(); }

// Make the IsMutable() check here instead of in |buffer_|, because the pool

// also has a reference to |buffer_|.

uint8_t* MutableDataY() override {

« no previous file with comments | « webrtc/call/call_perf_tests.cc ('k') | webrtc/media/base/fakemediaengine.h » ('j') | no next file with comments »