Enable more unittests on iOS, and disable those that fail on simulator

Enable more unittests on iOS, and disable those that fail on simulator

Tests enabled:
* modules_unittests
* ortc_unittests
* rtc_media_unittests
* rtc_unittests
* video_capture_tests
* video_engine_tests

BUG=webrtc:5566, webrtc:4752, webrtc:5568, webrtc:5569
Review-Url: https://codereview.webrtc.org/2938193002
Cr-Commit-Position: refs/heads/master@{#18710}
Committed: https://chromium.googlesource.com/external/webrtc/+/451975206a58334b6ac98a0023b2e5f90c945ab7

[oprypin_webrtc, 2017-06-15 21:59:51]

Description was changed from

==========
iOS: Enable more tests

BUG=webrtc:5566
==========

to

==========
iOS: Enable more tests

BUG=webrtc:5566,webrtc:4752,webrtc:5568,webrtc:5568
==========

[oprypin_webrtc, 2017-06-19 09:32:21]

Description was changed from

==========
iOS: Enable more tests

BUG=webrtc:5566,webrtc:4752,webrtc:5568,webrtc:5568
==========

to

==========
Enable more unittests on iOS, and disable those that fail on simulator

BUG=webrtc:5566,webrtc:4752,webrtc:5568,webrtc:5569
==========

[oprypin_webrtc, 2017-06-19 11:19:25]

oprypin@webrtc.org changed reviewers:
+ henrika@webrtc.org, kjellander@webrtc.org, kthelgason@webrtc.org,
magjed@webrtc.org

[kjellander_webrtc, 2017-06-19 12:51:05]

Description was changed from

==========
Enable more unittests on iOS, and disable those that fail on simulator

BUG=webrtc:5566,webrtc:4752,webrtc:5568,webrtc:5569
==========

to

==========
Enable more unittests on iOS, and disable those that fail on simulator

Tests enabled:
* modules_unittests
* ortc_unittests
* rtc_unittests
* video_capture_tests
* video_engine_tests

BUG=webrtc:5566,webrtc:4752,webrtc:5568,webrtc:5569
==========

[kjellander_webrtc, 2017-06-19 12:54:24]

lgtm - this is a huge amount of tests being added!

make sure to run all/some of the other trybots as well before landing.

[oprypin_webrtc, 2017-06-19 12:56:05]

On 2017/06/19 12:54:24, kjellander_webrtc wrote:
> lgtm - this is a huge amount of tests being added!
> 
> make sure to run all/some of the other trybots as well before landing.

Presubmit will run all trybots. Let me know if some internal bots should be ran
as well.

[oprypin_webrtc, 2017-06-20 09:37:07]

Ping

[magjed_webrtc, 2017-06-20 09:50:36]

lgtm

This is very welcome!

[oprypin_webrtc, 2017-06-20 13:38:34]

oprypin@webrtc.org changed reviewers:
+ stefan@webrtc.org
- kthelgason@webrtc.org

[oprypin_webrtc, 2017-06-20 13:39:16]

+stefan-webrtc for webrtc/video/end_to_end_tests.cc

[oprypin_webrtc, 2017-06-20 13:39:45]

Description was changed from

==========
Enable more unittests on iOS, and disable those that fail on simulator

Tests enabled:
* modules_unittests
* ortc_unittests
* rtc_unittests
* video_capture_tests
* video_engine_tests

BUG=webrtc:5566,webrtc:4752,webrtc:5568,webrtc:5569
==========

to

==========
Enable more unittests on iOS, and disable those that fail on simulator

Tests enabled:
* modules_unittests
* ortc_unittests
* rtc_media_unittests
* rtc_unittests
* video_capture_tests
* video_engine_tests

BUG=webrtc:5566,webrtc:4752,webrtc:5568,webrtc:5569
==========

[holmer, 2017-06-21 07:43:47]

holmer@google.com changed reviewers:
+ holmer@google.com

[holmer, 2017-06-21 07:43:48]

lgtm

[stefan-webrtc, 2017-06-21 07:43:54]

lgtm

[oprypin_webrtc, 2017-06-21 08:00:05]

The CQ bit was checked by oprypin@webrtc.org

[commit-bot: I haz the power, 2017-06-21 08:00:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-21 08:04:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 08:04:12]

Try jobs failed on following builders:
  android_compile_x64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg...)
  linux_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/27154)

[oprypin_webrtc, 2017-06-21 08:16:21]

The CQ bit was checked by oprypin@webrtc.org

[oprypin_webrtc, 2017-06-21 08:16:21]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org,
holmer@google.com, kjellander@webrtc.org, stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2938193002/#ps140001 (title:
"Fix define check")

[commit-bot: I haz the power, 2017-06-21 08:16:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-21 08:26:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 08:26:57]

Try jobs failed on following builders:
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/26770)

[oprypin_webrtc, 2017-06-21 12:49:21]

The CQ bit was checked by oprypin@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 12:49:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-21 13:19:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 13:19:13]

Dry run: This issue passed the CQ dry run.

[kthelgason, 2017-06-22 08:16:31]

kthelgason@webrtc.org changed reviewers:
+ kthelgason@webrtc.org

[kthelgason, 2017-06-22 08:16:32]

Thanks for getting this working Oleh. We should at some point try to figure out
why local simulator and bot simulator give different results, but not today!
lgtm

https://codereview.webrtc.org/2938193002/diff/180001/webrtc/media/engine/apm_...
File webrtc/media/engine/apm_helpers_unittest.cc (right):

https://codereview.webrtc.org/2938193002/diff/180001/webrtc/media/engine/apm_...
webrtc/media/engine/apm_helpers_unittest.cc:113: #if
defined(TARGET_IPHONE_SIMULATOR) && TARGET_IPHONE_SIMULATOR
I don't think there is any reason to check both, just #if
TARGET_IPHONE_SIMULATOR should be enough.

https://codereview.webrtc.org/2938193002/diff/180001/webrtc/media/engine/apm_...
webrtc/media/engine/apm_helpers_unittest.cc:257: #if
defined(TARGET_IPHONE_SIMULATOR) && TARGET_IPHONE_SIMULATOR
ditto

https://codereview.webrtc.org/2938193002/diff/180001/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/2938193002/diff/180001/webrtc/sdk/BUILD.gn#newc...
webrtc/sdk/BUILD.gn:382: (ios_sdk_version == "10.0" || ios_sdk_version ==
"10.1"))) {
Do the tests work on versions 10.2 and above?

[oprypin_webrtc, 2017-06-22 08:20:47]

https://codereview.webrtc.org/2938193002/diff/180001/webrtc/media/engine/apm_...
File webrtc/media/engine/apm_helpers_unittest.cc (right):

https://codereview.webrtc.org/2938193002/diff/180001/webrtc/media/engine/apm_...
webrtc/media/engine/apm_helpers_unittest.cc:113: #if
defined(TARGET_IPHONE_SIMULATOR) && TARGET_IPHONE_SIMULATOR
On 2017/06/22 08:16:32, kthelgason wrote:
> I don't think there is any reason to check both, just #if
> TARGET_IPHONE_SIMULATOR should be enough.

This macro is defined only on Mac, and using it directly elsewhere causes a
compilation error. See Patch Set 7 and fix in 8

https://codereview.webrtc.org/2938193002/diff/180001/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/2938193002/diff/180001/webrtc/sdk/BUILD.gn#newc...
webrtc/sdk/BUILD.gn:382: (ios_sdk_version == "10.0" || ios_sdk_version ==
"10.1"))) {
On 2017/06/22 08:16:32, kthelgason wrote:
> Do the tests work on versions 10.2 and above?

Yes, and 9.x work as well.

[oprypin_webrtc, 2017-06-22 08:23:19]

https://codereview.webrtc.org/2938193002/diff/180001/webrtc/media/engine/apm_...
File webrtc/media/engine/apm_helpers_unittest.cc (right):

https://codereview.webrtc.org/2938193002/diff/180001/webrtc/media/engine/apm_...
webrtc/media/engine/apm_helpers_unittest.cc:113: #if
defined(TARGET_IPHONE_SIMULATOR) && TARGET_IPHONE_SIMULATOR
On 2017/06/22 08:20:46, oprypin_webrtc wrote:
> On 2017/06/22 08:16:32, kthelgason wrote:
> > I don't think there is any reason to check both, just #if
> > TARGET_IPHONE_SIMULATOR should be enough.
> 
> This macro is defined only on Mac, and using it directly elsewhere causes a
> compilation error. See Patch Set 7 and fix in 8

Oh, and patch set 8 is not correct either, checking whether it's defined is
basically equivalent to "are we on Mac?", as it turns out.

[oprypin_webrtc, 2017-06-22 08:45:14]

The CQ bit was checked by oprypin@webrtc.org

[oprypin_webrtc, 2017-06-22 08:45:15]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org,
holmer@google.com, kjellander@webrtc.org, stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2938193002/#ps180001 (title:
"Disable webrtcvoiceengine_unittest.cc because it fails on iOS in general")

[commit-bot: I haz the power, 2017-06-22 08:45:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-22 08:47:20]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1498121114538490,
"parent_rev": "ab97e18fa97a73d8ad0ac51c11d7111dd397984d", "commit_rev":
"451975206a58334b6ac98a0023b2e5f90c945ab7"}

[commit-bot: I haz the power, 2017-06-22 08:47:24]

Description was changed from

==========
Enable more unittests on iOS, and disable those that fail on simulator

Tests enabled:
* modules_unittests
* ortc_unittests
* rtc_media_unittests
* rtc_unittests
* video_capture_tests
* video_engine_tests

BUG=webrtc:5566,webrtc:4752,webrtc:5568,webrtc:5569
==========

to

==========
Enable more unittests on iOS, and disable those that fail on simulator

Tests enabled:
* modules_unittests
* ortc_unittests
* rtc_media_unittests
* rtc_unittests
* video_capture_tests
* video_engine_tests

BUG=webrtc:5566,webrtc:4752,webrtc:5568,webrtc:5569

Review-Url: https://codereview.webrtc.org/2938193002
Cr-Commit-Position: refs/heads/master@{#18710}
Committed:
https://chromium.googlesource.com/external/webrtc/+/451975206a58334b6ac98a002...
==========

[commit-bot: I haz the power, 2017-06-22 08:47:26]

Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/external/webrtc/+/451975206a58334b6ac98a002...