Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Unified Diff: webrtc/sdk/BUILD.gn

Issue 2938193002: Enable more unittests on iOS, and disable those that fail on simulator (Closed)
Patch Set: Disable webrtcvoiceengine_unittest.cc because it fails on iOS in general Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/BUILD.gn
diff --git a/webrtc/sdk/BUILD.gn b/webrtc/sdk/BUILD.gn
index 78e10025801ad55d4dfc619fed2ddaca150ddeee..9fc22aa60f01be3d98a8e71a8411e579b2e3293c 100644
--- a/webrtc/sdk/BUILD.gn
+++ b/webrtc/sdk/BUILD.gn
@@ -9,6 +9,7 @@
import("../webrtc.gni")
if (is_ios) {
import("//build/config/ios/rules.gni")
+ import("//build/config/ios/ios_sdk.gni")
}
declare_args() {
@@ -366,7 +367,6 @@ if (is_ios || is_mac) {
visibility = [ "..:rtc_unittests" ]
}
sources = [
- "objc/Framework/UnitTests/RTCCameraVideoCapturerTests.mm",
"objc/Framework/UnitTests/RTCConfigurationTest.mm",
"objc/Framework/UnitTests/RTCDataChannelConfigurationTest.mm",
"objc/Framework/UnitTests/RTCIceCandidateTest.mm",
@@ -376,6 +376,13 @@ if (is_ios || is_mac) {
"objc/Framework/UnitTests/RTCSessionDescriptionTest.mm",
"objc/Framework/UnitTests/avformatmappertests.mm",
]
+ if (is_ios &&
+ !(use_ios_simulator &&
+ # The tests crash on these simulator versions:
+ (ios_sdk_version == "10.0" || ios_sdk_version == "10.1"))) {
kthelgason 2017/06/22 08:16:32 Do the tests work on versions 10.2 and above?
oprypin_webrtc 2017/06/22 08:20:46 Yes, and 9.x work as well.
+ sources +=
+ [ "objc/Framework/UnitTests/RTCCameraVideoCapturerTests.mm" ]
+ }
# |-ObjC| flag needed to make sure category method implementations
# are included:

Powered by Google App Engine
This is Rietveld 408576698