Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: webrtc/sdk/BUILD.gn

Issue 2938193002: Enable more unittests on iOS, and disable those that fail on simulator (Closed)
Patch Set: Disable webrtcvoiceengine_unittest.cc because it fails on iOS in general Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The WebRTC project authors. All Rights Reserved. 1 # Copyright 2016 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../webrtc.gni") 9 import("../webrtc.gni")
10 if (is_ios) { 10 if (is_ios) {
11 import("//build/config/ios/rules.gni") 11 import("//build/config/ios/rules.gni")
12 import("//build/config/ios/ios_sdk.gni")
12 } 13 }
13 14
14 declare_args() { 15 declare_args() {
15 # Determine whether or not to include metal rendering 16 # Determine whether or not to include metal rendering
16 rtc_use_metal_rendering = is_mac || (is_ios && current_cpu == "arm64") 17 rtc_use_metal_rendering = is_mac || (is_ios && current_cpu == "arm64")
17 } 18 }
18 19
19 group("sdk") { 20 group("sdk") {
20 if (!build_with_chromium && is_ios) { 21 if (!build_with_chromium && is_ios) {
21 public_deps = [ 22 public_deps = [
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
359 rtc_source_set("objc_sdk_unittests") { 360 rtc_source_set("objc_sdk_unittests") {
360 testonly = true 361 testonly = true
361 362
362 # Skip restricting visibility on mobile platforms since the tests on tho se 363 # Skip restricting visibility on mobile platforms since the tests on tho se
363 # gets additional generated targets which would require many lines here to 364 # gets additional generated targets which would require many lines here to
364 # cover (which would be confusing to read and hard to maintain). 365 # cover (which would be confusing to read and hard to maintain).
365 if (!is_android && !is_ios) { 366 if (!is_android && !is_ios) {
366 visibility = [ "..:rtc_unittests" ] 367 visibility = [ "..:rtc_unittests" ]
367 } 368 }
368 sources = [ 369 sources = [
369 "objc/Framework/UnitTests/RTCCameraVideoCapturerTests.mm",
370 "objc/Framework/UnitTests/RTCConfigurationTest.mm", 370 "objc/Framework/UnitTests/RTCConfigurationTest.mm",
371 "objc/Framework/UnitTests/RTCDataChannelConfigurationTest.mm", 371 "objc/Framework/UnitTests/RTCDataChannelConfigurationTest.mm",
372 "objc/Framework/UnitTests/RTCIceCandidateTest.mm", 372 "objc/Framework/UnitTests/RTCIceCandidateTest.mm",
373 "objc/Framework/UnitTests/RTCIceServerTest.mm", 373 "objc/Framework/UnitTests/RTCIceServerTest.mm",
374 "objc/Framework/UnitTests/RTCMediaConstraintsTest.mm", 374 "objc/Framework/UnitTests/RTCMediaConstraintsTest.mm",
375 "objc/Framework/UnitTests/RTCPeerConnectionTest.mm", 375 "objc/Framework/UnitTests/RTCPeerConnectionTest.mm",
376 "objc/Framework/UnitTests/RTCSessionDescriptionTest.mm", 376 "objc/Framework/UnitTests/RTCSessionDescriptionTest.mm",
377 "objc/Framework/UnitTests/avformatmappertests.mm", 377 "objc/Framework/UnitTests/avformatmappertests.mm",
378 ] 378 ]
379 if (is_ios &&
380 !(use_ios_simulator &&
381 # The tests crash on these simulator versions:
382 (ios_sdk_version == "10.0" || ios_sdk_version == "10.1"))) {
kthelgason 2017/06/22 08:16:32 Do the tests work on versions 10.2 and above?
oprypin_webrtc 2017/06/22 08:20:46 Yes, and 9.x work as well.
383 sources +=
384 [ "objc/Framework/UnitTests/RTCCameraVideoCapturerTests.mm" ]
385 }
379 386
380 # |-ObjC| flag needed to make sure category method implementations 387 # |-ObjC| flag needed to make sure category method implementations
381 # are included: 388 # are included:
382 # https://developer.apple.com/library/mac/qa/qa1490/_index.html 389 # https://developer.apple.com/library/mac/qa/qa1490/_index.html
383 ldflags = [ "-ObjC" ] 390 ldflags = [ "-ObjC" ]
384 391
385 defines = [ "GTEST_RELATIVE_PATH" ] 392 defines = [ "GTEST_RELATIVE_PATH" ]
386 deps = [ 393 deps = [
387 ":objc_peerconnection", 394 ":objc_peerconnection",
388 "..//system_wrappers:system_wrappers_default", 395 "..//system_wrappers:system_wrappers_default",
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
579 public_deps = [ 586 public_deps = [
580 "$rtc_libyuv_dir", 587 "$rtc_libyuv_dir",
581 ] 588 ]
582 } else { 589 } else {
583 # Need to add a directory normally exported by libyuv. 590 # Need to add a directory normally exported by libyuv.
584 include_dirs = [ "$rtc_libyuv_dir/include" ] 591 include_dirs = [ "$rtc_libyuv_dir/include" ]
585 } 592 }
586 } 593 }
587 } 594 }
588 } 595 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698