webrtc/modules/audio_device/BUILD.gn - Issue 2938193002: Enable more unittests on iOS, and disable those that fail on simulator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_device/BUILD.gn

Issue 2938193002: Enable more unittests on iOS, and disable those that fail on simulator (Closed)

Patch Set: Disable webrtcvoiceengine_unittest.cc because it fails on iOS in general Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_device/BUILD.gn

diff --git a/webrtc/modules/audio_device/BUILD.gn b/webrtc/modules/audio_device/BUILD.gn

index 511f15927213e0a5c1172041dd79b1caff76a79d..c737ac3cd5207cb7ca69e96c3c5fb53b3d6c0be2 100644

--- a/webrtc/modules/audio_device/BUILD.gn

+++ b/webrtc/modules/audio_device/BUILD.gn

@@ -307,7 +307,9 @@ if (rtc_include_tests) {

"//webrtc/sdk/android:libjingle_peerconnection_java",

]

}

- if (is_ios) {

+ if (is_ios && !use_ios_simulator) {

+ # TODO(kthelgason): Reenable these tests on simulator.

+ # See bugs.webrtc.org/7812

sources += [ "ios/audio_device_unittest_ios.mm" ]

deps += [ "//third_party/ocmock" ]

}