Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: webrtc/sdk/objc/Framework/UnitTests/RTCCameraVideoCapturerTests.mm

Issue 2938193002: Enable more unittests on iOS, and disable those that fail on simulator (Closed)
Patch Set: Disable webrtcvoiceengine_unittest.cc because it fails on iOS in general Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 [(id)currentDeviceMock stopMocking]; 210 [(id)currentDeviceMock stopMocking];
211 currentDeviceMock = nil; 211 currentDeviceMock = nil;
212 [classMock stopMocking]; 212 [classMock stopMocking];
213 classMock = nil; 213 classMock = nil;
214 CFRelease(sampleBuffer); 214 CFRelease(sampleBuffer);
215 #endif 215 #endif
216 } 216 }
217 217
218 @end 218 @end
219 219
220 TEST(RTCCameraVideoCapturerTests, SetupSession) { 220 // TODO(kthelgason): Reenable these tests on simulator.
221 // See bugs.webrtc.org/7813
222 #if TARGET_IPHONE_SIMULATOR
223 #define MAYBE_TEST(f, name) TEST(f, DISABLED_##name)
224 #else
225 #define MAYBE_TEST TEST
226 #endif
227
228 MAYBE_TEST(RTCCameraVideoCapturerTests, SetupSession) {
221 RTCCameraVideoCapturerTests *test = [[RTCCameraVideoCapturerTests alloc] init] ; 229 RTCCameraVideoCapturerTests *test = [[RTCCameraVideoCapturerTests alloc] init] ;
222 [test setup]; 230 [test setup];
223 [test testSetupSession]; 231 [test testSetupSession];
224 [test tearDown]; 232 [test tearDown];
225 } 233 }
226 234
227 TEST(RTCCameraVideoCapturerTests, SetupSessionOutput) { 235 MAYBE_TEST(RTCCameraVideoCapturerTests, SetupSessionOutput) {
228 RTCCameraVideoCapturerTests *test = [[RTCCameraVideoCapturerTests alloc] init] ; 236 RTCCameraVideoCapturerTests *test = [[RTCCameraVideoCapturerTests alloc] init] ;
229 [test setup]; 237 [test setup];
230 [test testSetupSessionOutput]; 238 [test testSetupSessionOutput];
231 [test tearDown]; 239 [test tearDown];
232 } 240 }
233 241
234 TEST(RTCCameraVideoCapturerTests, SupportedFormatsForDevice) { 242 MAYBE_TEST(RTCCameraVideoCapturerTests, SupportedFormatsForDevice) {
235 RTCCameraVideoCapturerTests *test = [[RTCCameraVideoCapturerTests alloc] init] ; 243 RTCCameraVideoCapturerTests *test = [[RTCCameraVideoCapturerTests alloc] init] ;
236 [test setup]; 244 [test setup];
237 [test testSupportedFormatsForDevice]; 245 [test testSupportedFormatsForDevice];
238 [test tearDown]; 246 [test tearDown];
239 } 247 }
240 248
241 TEST(RTCCameraVideoCapturerTests, CaptureDevices) { 249 MAYBE_TEST(RTCCameraVideoCapturerTests, CaptureDevices) {
242 RTCCameraVideoCapturerTests *test = [[RTCCameraVideoCapturerTests alloc] init] ; 250 RTCCameraVideoCapturerTests *test = [[RTCCameraVideoCapturerTests alloc] init] ;
243 [test setup]; 251 [test setup];
244 [test testCaptureDevices]; 252 [test testCaptureDevices];
245 [test tearDown]; 253 [test tearDown];
246 } 254 }
247 255
248 TEST(RTCCameraVideoCapturerTests, DelegateCallbackNotCalledWhenInvalidBuffer) { 256 MAYBE_TEST(RTCCameraVideoCapturerTests, DelegateCallbackNotCalledWhenInvalidBuff er) {
249 RTCCameraVideoCapturerTests *test = [[RTCCameraVideoCapturerTests alloc] init] ; 257 RTCCameraVideoCapturerTests *test = [[RTCCameraVideoCapturerTests alloc] init] ;
250 [test setup]; 258 [test setup];
251 [test testDelegateCallbackNotCalledWhenInvalidBuffer]; 259 [test testDelegateCallbackNotCalledWhenInvalidBuffer];
252 [test tearDown]; 260 [test tearDown];
253 } 261 }
254 262
255 TEST(RTCCameraVideoCapturerTests, DelegateCallbackWithValidBufferAndOrientationU pdate) { 263 MAYBE_TEST(RTCCameraVideoCapturerTests, DelegateCallbackWithValidBufferAndOrient ationUpdate) {
256 RTCCameraVideoCapturerTests *test = [[RTCCameraVideoCapturerTests alloc] init] ; 264 RTCCameraVideoCapturerTests *test = [[RTCCameraVideoCapturerTests alloc] init] ;
257 [test setup]; 265 [test setup];
258 [test testDelegateCallbackWithValidBufferAndOrientationUpdate]; 266 [test testDelegateCallbackWithValidBufferAndOrientationUpdate];
259 [test tearDown]; 267 [test tearDown];
260 } 268 }
OLDNEW
« webrtc/sdk/BUILD.gn ('K') | « webrtc/sdk/BUILD.gn ('k') | webrtc/video/end_to_end_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698