Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Side by Side Diff: webrtc/video/end_to_end_tests.cc

Issue 2938193002: Enable more unittests on iOS, and disable those that fail on simulator (Closed)
Patch Set: Disable webrtcvoiceengine_unittest.cc because it fails on iOS in general Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include <algorithm> 10 #include <algorithm>
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 #include "webrtc/test/frame_generator_capturer.h" 54 #include "webrtc/test/frame_generator_capturer.h"
55 #include "webrtc/test/gmock.h" 55 #include "webrtc/test/gmock.h"
56 #include "webrtc/test/gtest.h" 56 #include "webrtc/test/gtest.h"
57 #include "webrtc/test/null_transport.h" 57 #include "webrtc/test/null_transport.h"
58 #include "webrtc/test/rtcp_packet_parser.h" 58 #include "webrtc/test/rtcp_packet_parser.h"
59 #include "webrtc/test/rtp_rtcp_observer.h" 59 #include "webrtc/test/rtp_rtcp_observer.h"
60 #include "webrtc/test/testsupport/fileutils.h" 60 #include "webrtc/test/testsupport/fileutils.h"
61 #include "webrtc/test/testsupport/perf_test.h" 61 #include "webrtc/test/testsupport/perf_test.h"
62 #include "webrtc/video/transport_adapter.h" 62 #include "webrtc/video/transport_adapter.h"
63 63
64 // Flaky under MemorySanitizer: bugs.webrtc.org/7419
64 #if defined(MEMORY_SANITIZER) 65 #if defined(MEMORY_SANITIZER)
65 // Flaky under MemorySanitizer, see 66 #define MAYBE_InitialProbing DISABLED_InitialProbing
66 // https://bugs.chromium.org/p/webrtc/issues/detail?id=7419 67 // Fails on iOS bots: bugs.webrtc.org/7851
68 #elif defined(TARGET_IPHONE_SIMULATOR) && TARGET_IPHONE_SIMULATOR
67 #define MAYBE_InitialProbing DISABLED_InitialProbing 69 #define MAYBE_InitialProbing DISABLED_InitialProbing
68 #else 70 #else
69 #define MAYBE_InitialProbing InitialProbing 71 #define MAYBE_InitialProbing InitialProbing
70 #endif 72 #endif
71 73
72 namespace webrtc { 74 namespace webrtc {
73 75
74 namespace { 76 namespace {
75 constexpr int kSilenceTimeoutMs = 2000; 77 constexpr int kSilenceTimeoutMs = 2000;
76 } 78 }
(...skipping 2259 matching lines...) Expand 10 before | Expand all | Expand 10 after
2336 if (success) 2338 if (success)
2337 return; 2339 return;
2338 } 2340 }
2339 RTC_DCHECK(success) << "Failed to perform mid initial probing (" 2341 RTC_DCHECK(success) << "Failed to perform mid initial probing ("
2340 << kMaxAttempts << " attempts)."; 2342 << kMaxAttempts << " attempts).";
2341 } 2343 }
2342 2344
2343 // Fails on Linux MSan: bugs.webrtc.org/7428 2345 // Fails on Linux MSan: bugs.webrtc.org/7428
2344 #if defined(MEMORY_SANITIZER) 2346 #if defined(MEMORY_SANITIZER)
2345 TEST_F(EndToEndTest, DISABLED_TriggerMidCallProbing) { 2347 TEST_F(EndToEndTest, DISABLED_TriggerMidCallProbing) {
2348 // Fails on iOS bots: bugs.webrtc.org/7851
2349 #elif defined(TARGET_IPHONE_SIMULATOR) && TARGET_IPHONE_SIMULATOR
2350 TEST_F(EndToEndTest, DISABLED_TriggerMidCallProbing) {
2346 #else 2351 #else
2347 TEST_F(EndToEndTest, TriggerMidCallProbing) { 2352 TEST_F(EndToEndTest, TriggerMidCallProbing) {
2348 #endif 2353 #endif
2349 2354
2350 class TriggerMidCallProbingTest : public ProbingTest { 2355 class TriggerMidCallProbingTest : public ProbingTest {
2351 public: 2356 public:
2352 explicit TriggerMidCallProbingTest(bool* success) 2357 explicit TriggerMidCallProbingTest(bool* success)
2353 : ProbingTest(300000), success_(success) {} 2358 : ProbingTest(300000), success_(success) {}
2354 2359
2355 void PerformTest() override { 2360 void PerformTest() override {
(...skipping 2561 matching lines...) Expand 10 before | Expand all | Expand 10 after
4917 std::unique_ptr<VideoEncoder> encoder_; 4922 std::unique_ptr<VideoEncoder> encoder_;
4918 std::unique_ptr<VideoDecoder> decoder_; 4923 std::unique_ptr<VideoDecoder> decoder_;
4919 rtc::CriticalSection crit_; 4924 rtc::CriticalSection crit_;
4920 int recorded_frames_ GUARDED_BY(crit_); 4925 int recorded_frames_ GUARDED_BY(crit_);
4921 } test(this); 4926 } test(this);
4922 4927
4923 RunBaseTest(&test); 4928 RunBaseTest(&test);
4924 } 4929 }
4925 4930
4926 } // namespace webrtc 4931 } // namespace webrtc
OLDNEW
« webrtc/sdk/BUILD.gn ('K') | « webrtc/sdk/objc/Framework/UnitTests/RTCCameraVideoCapturerTests.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698