Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/media/BUILD.gn

Issue 2938193002: Enable more unittests on iOS, and disable those that fail on simulator (Closed)
Patch Set: Disable webrtcvoiceengine_unittest.cc because it fails on iOS in general Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools_webrtc/ios/tests/common_tests.json ('k') | webrtc/media/engine/apm_helpers_unittest.cc » ('j') | webrtc/media/engine/apm_helpers_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/BUILD.gn
diff --git a/webrtc/media/BUILD.gn b/webrtc/media/BUILD.gn
index ec00b049b696db4c62ac04785fb89d715fca74df..039f6aab502d377943c26e652cba2d35b4c27f06 100644
--- a/webrtc/media/BUILD.gn
+++ b/webrtc/media/BUILD.gn
@@ -443,9 +443,14 @@ if (rtc_include_tests) {
"engine/webrtcvideocapturer_unittest.cc",
"engine/webrtcvideoencoderfactory_unittest.cc",
"engine/webrtcvideoengine_unittest.cc",
- "engine/webrtcvoiceengine_unittest.cc",
]
+ # TODO(kthelgason): Reenable this test on iOS.
+ # See bugs.webrtc.org/5569
+ if (!is_ios) {
+ sources += [ "engine/webrtcvoiceengine_unittest.cc" ]
+ }
+
if (rtc_enable_sctp) {
sources += [ "sctp/sctptransport_unittest.cc" ]
}
« no previous file with comments | « tools_webrtc/ios/tests/common_tests.json ('k') | webrtc/media/engine/apm_helpers_unittest.cc » ('j') | webrtc/media/engine/apm_helpers_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698