GN Templates: Move common_config to the template.

GN Templates: Move common_config to the template.

Remove common_config from the targets' config and add
it to the template instead.

BUG=webrtc:6187
NOTRY=True

Committed: https://crrev.com/7a2ce0b73817bfe934062c207bfa638d23c6b809
Cr-Commit-Position: refs/heads/master@{#14063}

[ehmaldonado_webrtc, 2016-09-02 15:19:16]

Description was changed from

==========
Move common_config to the template

BUG=
==========

to

==========
GN Templates: Move common_config to the template.

Remove common_config from the targets' config and add
it to the template instead.

BUG=webrtc:6187
NOTRY=True
==========

[ehmaldonado_webrtc, 2016-09-02 15:19:53]

ehmaldonado@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[ehmaldonado_webrtc, 2016-09-02 15:19:54]

I tried locally with Linux and Android, I'm waiting for the tryjobs.

[ehmaldonado_webrtc, 2016-09-03 11:52:44]

Patchset #2 (id:20001) has been deleted

[kjellander_webrtc, 2016-09-05 06:50:29]

Love this cleanup. I just would like a few TODOs + cleanup bugs to be added to
this.

I fired Chromium trybots to ensure we don't break chromium.webrtc.fyi as well.

https://codereview.webrtc.org/2300413002/diff/40001/webrtc/build/webrtc.gni
File webrtc/build/webrtc.gni (right):

https://codereview.webrtc.org/2300413002/diff/40001/webrtc/build/webrtc.gni#n...
webrtc/build/webrtc.gni:164: rtc_common_config = webrtc_root + ":common_config"
Let's document this one properly. Something like this:

# Global configuration that should be applied to all WebRTC targets. You
normally shouldn't need to
# include this in your target as it's automatically included when using the
rtc_* templates.
# It sets defines, include paths and compilation warnings accordingly, both for
WebRTC
# stand-alone builds and for the scenario when WebRTC native code is built as
part of Chromium.

https://codereview.webrtc.org/2300413002/diff/40001/webrtc/examples/BUILD.gn
File webrtc/examples/BUILD.gn (right):

https://codereview.webrtc.org/2300413002/diff/40001/webrtc/examples/BUILD.gn#...
webrtc/examples/BUILD.gn:412: suppressed_configs += [ rtc_common_config ]
Add a TODO(ehmaldonado) here, preferably pointing to a tracking bug as well
(file a new bug for getting the examples to compile with our standard set of
warnings).

https://codereview.webrtc.org/2300413002/diff/40001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/BUILD.gn (right):

https://codereview.webrtc.org/2300413002/diff/40001/webrtc/modules/video_codi...
webrtc/modules/video_coding/BUILD.gn:190: suppressed_configs += [
rtc_common_config ]
Is this needed? Since it's not a part of examples/tests I would assume the GYP
version already had the common_config in the GYP build, so it really should pass
compilation.

Otherwise: add a TODO+bug for cleanup (and assign the bug to hbos@).

https://codereview.webrtc.org/2300413002/diff/40001/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/2300413002/diff/40001/webrtc/sdk/BUILD.gn#newco...
webrtc/sdk/BUILD.gn:189: suppressed_configs += [ rtc_common_config ]
Same here, if needed, add a TODO (separate bug from the others). In this case
you can assign the bug to tkchin@.

[ehmaldonado_webrtc, 2016-09-05 07:40:21]

On 2016/09/05 06:50:29, kjellander_webrtc wrote:
> Love this cleanup. I just would like a few TODOs + cleanup bugs to be added to
> this.
> 
> I fired Chromium trybots to ensure we don't break chromium.webrtc.fyi as well.
> 
> https://codereview.webrtc.org/2300413002/diff/40001/webrtc/build/webrtc.gni
> File webrtc/build/webrtc.gni (right):
> 
>
https://codereview.webrtc.org/2300413002/diff/40001/webrtc/build/webrtc.gni#n...
> webrtc/build/webrtc.gni:164: rtc_common_config = webrtc_root +
":common_config"
> Let's document this one properly. Something like this:
> 
> # Global configuration that should be applied to all WebRTC targets. You
> normally shouldn't need to
> # include this in your target as it's automatically included when using the
> rtc_* templates.
> # It sets defines, include paths and compilation warnings accordingly, both
for
> WebRTC
> # stand-alone builds and for the scenario when WebRTC native code is built as
> part of Chromium.
> 
> https://codereview.webrtc.org/2300413002/diff/40001/webrtc/examples/BUILD.gn
> File webrtc/examples/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2300413002/diff/40001/webrtc/examples/BUILD.gn#...
> webrtc/examples/BUILD.gn:412: suppressed_configs += [ rtc_common_config ]
> Add a TODO(ehmaldonado) here, preferably pointing to a tracking bug as well
> (file a new bug for getting the examples to compile with our standard set of
> warnings).
> 
>
https://codereview.webrtc.org/2300413002/diff/40001/webrtc/modules/video_codi...
> File webrtc/modules/video_coding/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2300413002/diff/40001/webrtc/modules/video_codi...
> webrtc/modules/video_coding/BUILD.gn:190: suppressed_configs += [
> rtc_common_config ]
> Is this needed? Since it's not a part of examples/tests I would assume the GYP
> version already had the common_config in the GYP build, so it really should
pass
> compilation.
> 
> Otherwise: add a TODO+bug for cleanup (and assign the bug to hbos@).
> 
> https://codereview.webrtc.org/2300413002/diff/40001/webrtc/sdk/BUILD.gn
> File webrtc/sdk/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2300413002/diff/40001/webrtc/sdk/BUILD.gn#newco...
> webrtc/sdk/BUILD.gn:189: suppressed_configs += [ rtc_common_config ]
> Same here, if needed, add a TODO (separate bug from the others). In this case
> you can assign the bug to tkchin@.

PTAL.
Yes, they're needed. They didn't have common_config before either. Added TODOs
and tracking bugs.

[kjellander_webrtc, 2016-09-05 08:26:10]

lgtm, since Chromium tryjobs seems to pass green

[ehmaldonado_webrtc, 2016-09-05 08:27:36]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2016-09-05 08:27:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-05 08:35:47]

Description was changed from

==========
GN Templates: Move common_config to the template.

Remove common_config from the targets' config and add
it to the template instead.

BUG=webrtc:6187
NOTRY=True
==========

to

==========
GN Templates: Move common_config to the template.

Remove common_config from the targets' config and add
it to the template instead.

BUG=webrtc:6187
NOTRY=True
==========

[commit-bot: I haz the power, 2016-09-05 08:35:49]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-09-05 08:35:54]

Description was changed from

==========
GN Templates: Move common_config to the template.

Remove common_config from the targets' config and add
it to the template instead.

BUG=webrtc:6187
NOTRY=True
==========

to

==========
GN Templates: Move common_config to the template.

Remove common_config from the targets' config and add
it to the template instead.

BUG=webrtc:6187
NOTRY=True

Committed: https://crrev.com/7a2ce0b73817bfe934062c207bfa638d23c6b809
Cr-Commit-Position: refs/heads/master@{#14063}
==========

[commit-bot: I haz the power, 2016-09-05 08:35:55]

Patchset 3 (id:??) landed as
https://crrev.com/7a2ce0b73817bfe934062c207bfa638d23c6b809
Cr-Commit-Position: refs/heads/master@{#14063}