Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: webrtc/sdk/BUILD.gn

Issue 2300413002: GN Templates: Move common_config to the template. (Closed)
Patch Set: Add TODOs + tracking bugs. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/pc/BUILD.gn ('k') | webrtc/stats/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/sdk/BUILD.gn
diff --git a/webrtc/sdk/BUILD.gn b/webrtc/sdk/BUILD.gn
index 69ec091a790314c9f75ad73facf7f045b033bad3..6e21f53def18a558fbc9e69a7be55bf4e0d868cd 100644
--- a/webrtc/sdk/BUILD.gn
+++ b/webrtc/sdk/BUILD.gn
@@ -22,10 +22,7 @@ if (is_ios || (is_mac && mac_deployment_target == "10.7")) {
deps = [
"../base:rtc_base",
]
- configs += [
- "..:common_config",
- "//build/config/compiler:enable_arc",
- ]
+ configs += [ "//build/config/compiler:enable_arc" ]
public_configs = [
"..:common_inherited_config",
":rtc_sdk_common_objc_config",
@@ -190,6 +187,11 @@ if (is_ios || (is_mac && mac_deployment_target == "10.7")) {
"//build/config/compiler:enable_arc",
]
+ # TODO(tkchin): Make rtc_sdk_peerconnection_objc compile with the standard
+ # set of warnings.
+ # See https://bugs.chromium.org/p/webrtc/issues/detail?id=6308
+ suppressed_configs += [ rtc_common_config ]
+
public_configs = [ ":rtc_sdk_common_objc_config" ]
if (is_clang) {
« no previous file with comments | « webrtc/pc/BUILD.gn ('k') | webrtc/stats/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698