Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Side by Side Diff: webrtc/sdk/BUILD.gn

Issue 2300413002: GN Templates: Move common_config to the template. (Closed)
Patch Set: Add TODOs + tracking bugs. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/pc/BUILD.gn ('k') | webrtc/stats/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The WebRTC project authors. All Rights Reserved. 1 # Copyright 2016 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../build/webrtc.gni") 9 import("../build/webrtc.gni")
10 import("//build_overrides/webrtc.gni") 10 import("//build_overrides/webrtc.gni")
11 import("//build/config/mac/mac_sdk.gni") 11 import("//build/config/mac/mac_sdk.gni")
12 12
13 if (is_ios || (is_mac && mac_deployment_target == "10.7")) { 13 if (is_ios || (is_mac && mac_deployment_target == "10.7")) {
14 config("rtc_sdk_common_objc_config") { 14 config("rtc_sdk_common_objc_config") {
15 include_dirs = [ 15 include_dirs = [
16 "objc/Framework/Classes", 16 "objc/Framework/Classes",
17 "objc/Framework/Headers", 17 "objc/Framework/Headers",
18 ] 18 ]
19 } 19 }
20 20
21 rtc_source_set("rtc_sdk_common_objc") { 21 rtc_source_set("rtc_sdk_common_objc") {
22 deps = [ 22 deps = [
23 "../base:rtc_base", 23 "../base:rtc_base",
24 ] 24 ]
25 configs += [ 25 configs += [ "//build/config/compiler:enable_arc" ]
26 "..:common_config",
27 "//build/config/compiler:enable_arc",
28 ]
29 public_configs = [ 26 public_configs = [
30 "..:common_inherited_config", 27 "..:common_inherited_config",
31 ":rtc_sdk_common_objc_config", 28 ":rtc_sdk_common_objc_config",
32 ] 29 ]
33 sources = [ 30 sources = [
34 "objc/Framework/Classes/NSString+StdString.h", 31 "objc/Framework/Classes/NSString+StdString.h",
35 "objc/Framework/Classes/NSString+StdString.mm", 32 "objc/Framework/Classes/NSString+StdString.mm",
36 "objc/Framework/Classes/RTCDispatcher.m", 33 "objc/Framework/Classes/RTCDispatcher.m",
37 "objc/Framework/Classes/RTCFieldTrials.mm", 34 "objc/Framework/Classes/RTCFieldTrials.mm",
38 "objc/Framework/Classes/RTCLogging.mm", 35 "objc/Framework/Classes/RTCLogging.mm",
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 "CoreMedia.framework", 180 "CoreMedia.framework",
184 "OpenGL.framework", 181 "OpenGL.framework",
185 ] 182 ]
186 } 183 }
187 184
188 configs += [ 185 configs += [
189 "..:common_objc", 186 "..:common_objc",
190 "//build/config/compiler:enable_arc", 187 "//build/config/compiler:enable_arc",
191 ] 188 ]
192 189
190 # TODO(tkchin): Make rtc_sdk_peerconnection_objc compile with the standard
191 # set of warnings.
192 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=6308
193 suppressed_configs += [ rtc_common_config ]
194
193 public_configs = [ ":rtc_sdk_common_objc_config" ] 195 public_configs = [ ":rtc_sdk_common_objc_config" ]
194 196
195 if (is_clang) { 197 if (is_clang) {
196 # Suppress warnings from the Chromium Clang plugins. 198 # Suppress warnings from the Chromium Clang plugins.
197 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. 199 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
198 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 200 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
199 } 201 }
200 202
201 libs += [ "AVFoundation.framework" ] 203 libs += [ "AVFoundation.framework" ]
202 204
203 deps = [ 205 deps = [
204 ":rtc_sdk_common_objc", 206 ":rtc_sdk_common_objc",
205 "../api:libjingle_peerconnection", 207 "../api:libjingle_peerconnection",
206 ] 208 ]
207 209
208 if (rtc_build_libyuv) { 210 if (rtc_build_libyuv) {
209 deps += [ "$rtc_libyuv_dir" ] 211 deps += [ "$rtc_libyuv_dir" ]
210 public_deps = [ 212 public_deps = [
211 "$rtc_libyuv_dir", 213 "$rtc_libyuv_dir",
212 ] 214 ]
213 } 215 }
214 } 216 }
215 217
216 # TODO(tkchin): Add the rtc_sdk_framework_objc target. 218 # TODO(tkchin): Add the rtc_sdk_framework_objc target.
217 } 219 }
OLDNEW
« no previous file with comments | « webrtc/pc/BUILD.gn ('k') | webrtc/stats/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698