Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: webrtc/tools/BUILD.gn

Issue 2300413002: GN Templates: Move common_config to the template. (Closed)
Patch Set: Add TODOs + tracking bugs. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/test/BUILD.gn ('k') | webrtc/video/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/tools/BUILD.gn
diff --git a/webrtc/tools/BUILD.gn b/webrtc/tools/BUILD.gn
index 8724aca15bd2273d846fde297ba28fca7970d7d8..d09a8d4507531d36e7176c5589820d5e53a9809d 100644
--- a/webrtc/tools/BUILD.gn
+++ b/webrtc/tools/BUILD.gn
@@ -31,7 +31,6 @@ rtc_source_set("command_line_parser") {
deps = [
"../base:gtest_prod",
]
- configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
}
@@ -41,7 +40,6 @@ rtc_source_set("video_quality_analysis") {
"frame_analyzer/video_quality_analysis.h",
]
- configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
deps = [
@@ -57,7 +55,6 @@ rtc_executable("frame_analyzer") {
"frame_analyzer/frame_analyzer.cc",
]
- configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
deps = [
@@ -72,7 +69,6 @@ rtc_executable("psnr_ssim_analyzer") {
"psnr_ssim_analyzer/psnr_ssim_analyzer.cc",
]
- configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
deps = [
@@ -89,7 +85,6 @@ rtc_executable("rgba_to_i420_converter") {
"converter/rgba_to_i420_converter.cc",
]
- configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
deps = [
@@ -105,7 +100,6 @@ rtc_source_set("frame_editing_lib") {
"frame_editing/frame_editing_lib.h",
]
- configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
# TODO(jschuh): Bug 1348: fix this warning.
@@ -127,7 +121,6 @@ rtc_executable("frame_editor") {
"frame_editing/frame_editing.cc",
]
- configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
deps = [
@@ -142,7 +135,6 @@ rtc_executable("force_mic_volume_max") {
"force_mic_volume_max/force_mic_volume_max.cc",
]
- configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
if (is_clang) {
@@ -177,7 +169,6 @@ if (rtc_enable_protobuf) {
"event_log_visualizer/plot_python.cc",
"event_log_visualizer/plot_python.h",
]
- configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
if (is_clang && !is_nacl) {
# Suppress warnings from the Chromium Clang plugin.
@@ -209,7 +200,6 @@ if (rtc_include_tests) {
"event_log_visualizer/main.cc",
]
- configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
if (is_clang && !is_nacl) {
@@ -232,7 +222,6 @@ if (rtc_include_tests) {
"agc/activity_metric.cc",
]
- configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
if (is_clang) {
@@ -256,7 +245,6 @@ if (rtc_include_tests) {
"e2e_quality/audio/audio_e2e_harness.cc",
]
- configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
if (is_clang) {
@@ -298,7 +286,6 @@ if (rtc_include_tests) {
"simple_command_line_parser_unittest.cc",
]
- configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
# TODO(jschuh): Bug 1348: fix this warning.
« no previous file with comments | « webrtc/test/BUILD.gn ('k') | webrtc/video/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698