Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Side by Side Diff: webrtc/modules/remote_bitrate_estimator/BUILD.gn

Issue 2300413002: GN Templates: Move common_config to the template. (Closed)
Patch Set: Add TODOs + tracking bugs. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/pacing/BUILD.gn ('k') | webrtc/modules/rtp_rtcp/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../../build/webrtc.gni") 9 import("../../build/webrtc.gni")
10 10
(...skipping 28 matching lines...) Expand all
39 "transport_feedback_adapter.h", 39 "transport_feedback_adapter.h",
40 ] 40 ]
41 41
42 if (rtc_enable_bwe_test_logging) { 42 if (rtc_enable_bwe_test_logging) {
43 defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=1" ] 43 defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=1" ]
44 sources += [ "test/bwe_test_logging.cc" ] 44 sources += [ "test/bwe_test_logging.cc" ]
45 } else { 45 } else {
46 defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0" ] 46 defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0" ]
47 } 47 }
48 48
49 configs += [ "../..:common_config" ]
50 public_configs = [ "../..:common_inherited_config" ] 49 public_configs = [ "../..:common_inherited_config" ]
51 50
52 if (is_clang) { 51 if (is_clang) {
53 # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163). 52 # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163).
54 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 53 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
55 } 54 }
56 55
57 deps = [ 56 deps = [
58 "../..:webrtc_common", 57 "../..:webrtc_common",
59 "../../base:rtc_base_approved", 58 "../../base:rtc_base_approved",
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 "test/packet_sender.h", 92 "test/packet_sender.h",
94 ] 93 ]
95 94
96 if (rtc_enable_bwe_test_logging) { 95 if (rtc_enable_bwe_test_logging) {
97 defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=1" ] 96 defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=1" ]
98 sources += [ "test/bwe_test_logging.cc" ] 97 sources += [ "test/bwe_test_logging.cc" ]
99 } else { 98 } else {
100 defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0" ] 99 defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0" ]
101 } 100 }
102 101
103 configs += [ "../..:common_config" ]
104 public_configs = [ "../..:common_inherited_config" ] 102 public_configs = [ "../..:common_inherited_config" ]
105 103
106 if (is_clang) { 104 if (is_clang) {
107 # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163). 105 # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163).
108 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 106 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
109 } 107 }
110 108
111 if (is_win) { 109 if (is_win) {
112 cflags = [ 110 cflags = [
113 # TODO(kjellander): Bug 261: fix this warning. 111 # TODO(kjellander): Bug 261: fix this warning.
114 "/wd4373", # virtual function override. 112 "/wd4373", # virtual function override.
115 ] 113 ]
116 } 114 }
117 115
118 deps = [ 116 deps = [
119 "../../test:test_support", 117 "../../test:test_support",
120 "../pacing", 118 "../pacing",
121 "//testing/gmock", 119 "//testing/gmock",
122 "//testing/gtest", 120 "//testing/gtest",
123 ] 121 ]
124 } 122 }
125 } 123 }
OLDNEW
« no previous file with comments | « webrtc/modules/pacing/BUILD.gn ('k') | webrtc/modules/rtp_rtcp/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698