Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1834)

Unified Diff: webrtc/examples/BUILD.gn

Issue 2300413002: GN Templates: Move common_config to the template. (Closed)
Patch Set: Add TODOs + tracking bugs. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/common_video/BUILD.gn ('k') | webrtc/libjingle/xmllite/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/examples/BUILD.gn
diff --git a/webrtc/examples/BUILD.gn b/webrtc/examples/BUILD.gn
index de88afb1defc9feaff787d3edb21a8ee74fced3f..f60f55994e18c67c119e0e0ae3c2e855129a2c70 100644
--- a/webrtc/examples/BUILD.gn
+++ b/webrtc/examples/BUILD.gn
@@ -140,7 +140,6 @@ if (is_ios || (is_mac && target_cpu != "x86")) {
"objc/AppRTCDemo/common/ARDUtilities.m",
]
configs += [
- "..:common_config",
":warnings_config",
"//build/config/compiler:enable_arc",
]
@@ -209,7 +208,6 @@ if (is_ios || (is_mac && target_cpu != "x86")) {
"objc/AppRTCDemo/RTCSessionDescription+JSON.m",
]
configs += [
- "..:common_config",
"//build/config/compiler:enable_arc",
":warnings_config",
]
@@ -299,7 +297,6 @@ if (is_ios || (is_mac && target_cpu != "x86")) {
"objc/AppRTCDemo/mac/APPRTCViewController.m",
]
configs += [
- "..:common_config",
"..:common_objc",
"//build/config/compiler:enable_arc",
]
@@ -360,7 +357,6 @@ if (is_ios || (is_mac && target_cpu != "x86")) {
"objc/AppRTCDemo/third_party/SocketRocket/SRWebSocket.m",
]
configs += [
- "..:common_config",
"//build/config/compiler:enable_arc",
":socketrocket_warning_config",
]
@@ -413,6 +409,11 @@ if (is_linux || is_win) {
"peerconnection/client/peer_connection_client.cc",
"peerconnection/client/peer_connection_client.h",
]
+
+ # TODO(ehmaldonado): Make peerconnection_client compile with the standard
+ # set of warnings.
+ # See https://bugs.chromium.org/p/webrtc/issues/detail?id=6306
+ suppressed_configs += [ rtc_common_config ]
if (is_clang) {
# Suppress warnings from the Chromium Clang plugin.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
« no previous file with comments | « webrtc/common_video/BUILD.gn ('k') | webrtc/libjingle/xmllite/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698