Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: webrtc/base/BUILD.gn

Issue 2300413002: GN Templates: Move common_config to the template. (Closed)
Patch Set: Add TODOs + tracking bugs. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/audio/BUILD.gn ('k') | webrtc/build/webrtc.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/BUILD.gn
diff --git a/webrtc/base/BUILD.gn b/webrtc/base/BUILD.gn
index aeb2f355584bdfc1a180cd6ce843920e85fc5eff..e7c01bef13d49732f73980d8260e00708caf94f8 100644
--- a/webrtc/base/BUILD.gn
+++ b/webrtc/base/BUILD.gn
@@ -94,7 +94,6 @@ rtc_static_library("rtc_base_approved") {
defines = []
libs = []
deps = []
- configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
all_dependent_configs = [ ":rtc_base_approved_all_dependent_config" ]
@@ -212,7 +211,6 @@ rtc_static_library("rtc_task_queue") {
public_deps = [
":rtc_base_approved",
]
- configs += [ "..:common_config" ]
sources = [
"sequenced_task_checker.h",
@@ -280,7 +278,6 @@ rtc_static_library("rtc_base") {
]
configs += [
- "..:common_config",
":openssl_config",
":rtc_base_config",
]
@@ -734,10 +731,7 @@ if (rtc_include_tests) {
"timedelta.h",
"unittest_main.cc",
]
- configs += [
- "..:common_config",
- ":rtc_base_tests_utils_warnings_config",
- ]
+ configs += [ ":rtc_base_tests_utils_warnings_config" ]
public_configs = [
"..:common_inherited_config",
":rtc_base_tests_utils_exported_config",
« no previous file with comments | « webrtc/audio/BUILD.gn ('k') | webrtc/build/webrtc.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698