Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1492)

Unified Diff: webrtc/BUILD.gn

Issue 2300413002: GN Templates: Move common_config to the template. (Closed)
Patch Set: Add TODOs + tracking bugs. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/BUILD.gn
diff --git a/webrtc/BUILD.gn b/webrtc/BUILD.gn
index ae109a14352669e38b56ec69a56ab5f05baa3d33..aaa1d72f96bdb3eb457d40a426022355d30d24ea 100644
--- a/webrtc/BUILD.gn
+++ b/webrtc/BUILD.gn
@@ -247,7 +247,6 @@ if (!is_ios || !build_with_chromium) {
]
defines = []
- configs += [ ":common_config" ]
public_configs = [ ":common_inherited_config" ]
deps = [
@@ -338,7 +337,6 @@ rtc_source_set("webrtc_common") {
"typedefs.h",
]
- configs += [ ":common_config" ]
public_configs = [ ":common_inherited_config" ]
if (is_clang && !is_nacl) {
@@ -366,7 +364,6 @@ rtc_source_set("rtc_event_log") {
]
defines = []
- configs += [ ":common_config" ]
public_configs = [ ":common_inherited_config" ]
deps = [
@@ -392,7 +389,6 @@ if (rtc_enable_protobuf) {
"call/rtc_event_log_parser.h",
]
- configs += [ ":common_config" ]
public_configs = [ ":common_inherited_config" ]
public_deps = [
@@ -586,10 +582,7 @@ if (rtc_include_tests) {
]
}
- configs += [
- ":common_config",
- ":rtc_unittests_config",
- ]
+ configs += [ ":rtc_unittests_config" ]
public_configs = [ ":common_inherited_config" ]
if (is_clang) {
@@ -638,10 +631,7 @@ if (rtc_include_tests) {
}
rtc_test("xmllite_xmpp_unittests") {
- configs += [
- ":common_config",
- ":rtc_unittests_config",
- ]
+ configs += [ ":rtc_unittests_config" ]
public_configs = [ ":common_inherited_config" ]
if (is_clang) {
@@ -728,7 +718,6 @@ if (rtc_include_tests) {
rtc_source_set("video_quality_test") {
testonly = true
- configs += [ ":common_config" ]
public_configs = [ ":common_inherited_config" ]
sources = [
"video/video_quality_test.cc",
@@ -778,10 +767,7 @@ if (rtc_include_tests) {
rtc_test("webrtc_perf_tests") {
testonly = true
- configs += [
- ":common_config",
- ":rtc_unittests_config",
- ]
+ configs += [ ":rtc_unittests_config" ]
public_configs = [ ":common_inherited_config" ]
if (!is_debug) {
@@ -832,10 +818,7 @@ if (rtc_include_tests) {
rtc_test("webrtc_nonparallel_tests") {
testonly = true
- configs += [
- ":common_config",
- ":rtc_unittests_config",
- ]
+ configs += [ ":rtc_unittests_config" ]
public_configs = [ ":common_inherited_config" ]
sources = [
"base/nullsocketserver_unittest.cc",
« no previous file with comments | « no previous file | webrtc/api/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698