[rtp_rtcp] rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer

[rtp_rtcp] rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer

rtcp::RawPacket is rtc::Buffer, it had no extra functionality.
rtc::Buffer is a movable class - no point to wrap it into rtc::scoped_ptr
change is large, but straightforward:
  rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer
  ->Buffer() replaced with .data()
  ->Length() replaced with .size()

BUG=webrtc:5260
Committed: https://crrev.com/69e59e619a190ee11258ef73d404994805be6d22
Cr-Commit-Position: refs/heads/master@{#11649}

[danilchap, 2016-02-16 09:59:35]

danilchap@webrtc.org changed reviewers:
+ sprang@webrtc.org

[danilchap, 2016-02-16 09:59:35]

If this CL is too big, it could be split into several, but in a hacky way:
https://codereview.webrtc.org/1699043002/

[pbos-webrtc, 2016-02-16 10:31:22]

pbos@webrtc.org changed reviewers:
+ pbos@webrtc.org

[pbos-webrtc, 2016-02-16 10:31:23]

lgtm

https://codereview.webrtc.org/1696203002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc
(right):

https://codereview.webrtc.org/1696203002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc:47:
header, packet.data() + RtcpCommonHeader::kHeaderSizeBytes));
I think I've seen this function far too many times. Consider making a common
test class for all of these in a follow-up CL.

[danilchap, 2016-02-16 11:28:37]

Description was changed from

==========
[rtp_rtcp] rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer

rtcp::RawPacket is rtc::Buffer, it had no extra functionality.
rtc::Buffer is a movable class - no point to wrap it into rtc::scoped_ptr
change is large, but straightforward:
  rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer
  ->Buffer() replaced with .data()
  ->Length() replaced with .size()

BUG=webrtc:5260
==========

to

==========
[rtp_rtcp] rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer

rtcp::RawPacket is rtc::Buffer, it had no extra functionality.
rtc::Buffer is a movable class - no point to wrap it into rtc::scoped_ptr
change is large, but straightforward:
  rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer
  ->Buffer() replaced with .data()
  ->Length() replaced with .size()

BUG=webrtc:5260
==========

[danilchap, 2016-02-16 11:28:37]

danilchap@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2016-02-17 09:48:35]

rs lgtm

[danilchap, 2016-02-17 09:50:27]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2016-02-17 09:50:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1696203002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1696203002/1

[commit-bot: I haz the power, 2016-02-17 10:51:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 10:51:04]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

Transient error: Can't process patch for file
webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports_unittest.cc.
Diff seems corrupted.

[commit-bot: I haz the power, 2016-02-17 10:51:05]

The CQ bit was unchecked by commit-bot@chromium.org

[danilchap, 2016-02-17 11:07:45]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2016-02-17 11:07:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1696203002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1696203002/1

[commit-bot: I haz the power, 2016-02-17 11:11:44]

Description was changed from

==========
[rtp_rtcp] rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer

rtcp::RawPacket is rtc::Buffer, it had no extra functionality.
rtc::Buffer is a movable class - no point to wrap it into rtc::scoped_ptr
change is large, but straightforward:
  rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer
  ->Buffer() replaced with .data()
  ->Length() replaced with .size()

BUG=webrtc:5260
==========

to

==========
[rtp_rtcp] rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer

rtcp::RawPacket is rtc::Buffer, it had no extra functionality.
rtc::Buffer is a movable class - no point to wrap it into rtc::scoped_ptr
change is large, but straightforward:
  rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer
  ->Buffer() replaced with .data()
  ->Length() replaced with .size()

BUG=webrtc:5260
==========

[commit-bot: I haz the power, 2016-02-17 11:11:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-17 11:11:55]

Description was changed from

==========
[rtp_rtcp] rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer

rtcp::RawPacket is rtc::Buffer, it had no extra functionality.
rtc::Buffer is a movable class - no point to wrap it into rtc::scoped_ptr
change is large, but straightforward:
  rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer
  ->Buffer() replaced with .data()
  ->Length() replaced with .size()

BUG=webrtc:5260
==========

to

==========
[rtp_rtcp] rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer

rtcp::RawPacket is rtc::Buffer, it had no extra functionality.
rtc::Buffer is a movable class - no point to wrap it into rtc::scoped_ptr
change is large, but straightforward:
  rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer
  ->Buffer() replaced with .data()
  ->Length() replaced with .size()

BUG=webrtc:5260

Committed: https://crrev.com/69e59e619a190ee11258ef73d404994805be6d22
Cr-Commit-Position: refs/heads/master@{#11649}
==========

[commit-bot: I haz the power, 2016-02-17 11:11:56]

Patchset 1 (id:??) landed as
https://crrev.com/69e59e619a190ee11258ef73d404994805be6d22
Cr-Commit-Position: refs/heads/master@{#11649}