webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc - Issue 1696203002: [rtp_rtcp] rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc

Issue 1696203002: [rtp_rtcp] rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/nack_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/rapid_resync_request_unittest.cc » ('j') | webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc

index 1c47c3ffb12b04399b1d7b96cd1654084c722c46..09e8f5898f561ea6b37c05c71ec527cfe8358cb3 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc

@@ -14,7 +14,6 @@

#include "webrtc/modules/rtp_rtcp/source/rtcp_utility.h"

using webrtc::rtcp::Pli;

-using webrtc::rtcp::RawPacket;

using webrtc::RTCPUtility::RtcpCommonHeader;

using webrtc::RTCPUtility::RtcpParseCommonHeader;

@@ -46,10 +45,10 @@ TEST(RtcpPacketPliTest, Create) {

pli.From(kSenderSsrc);

pli.To(kRemoteSsrc);

- rtc::scoped_ptr<RawPacket> packet(pli.Build());

+ rtc::Buffer packet = pli.Build();

- ASSERT_EQ(kPacketLength, packet->Length());

- EXPECT_EQ(0, memcmp(kPacket, packet->Buffer(), kPacketLength));

+ ASSERT_EQ(kPacketLength, packet.size());

+ EXPECT_EQ(0, memcmp(kPacket, packet.data(), kPacketLength));

}

TEST(RtcpPacketPliTest, ParseFailsOnTooSmallPacket) {