Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn_unittest.cc

Issue 1696203002: [rtp_rtcp] rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h" 11 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h"
12 12
13 #include "testing/gmock/include/gmock/gmock.h" 13 #include "testing/gmock/include/gmock/gmock.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 15
16 using testing::ElementsAreArray; 16 using testing::ElementsAreArray;
17 using testing::IsEmpty; 17 using testing::IsEmpty;
18 using testing::make_tuple; 18 using testing::make_tuple;
19 using webrtc::rtcp::RawPacket;
20 using webrtc::rtcp::TmmbItem; 19 using webrtc::rtcp::TmmbItem;
21 using webrtc::rtcp::Tmmbn; 20 using webrtc::rtcp::Tmmbn;
22 using webrtc::RTCPUtility::RtcpCommonHeader; 21 using webrtc::RTCPUtility::RtcpCommonHeader;
23 using webrtc::RTCPUtility::RtcpParseCommonHeader; 22 using webrtc::RTCPUtility::RtcpParseCommonHeader;
24 23
25 namespace webrtc { 24 namespace webrtc {
26 namespace { 25 namespace {
27 const uint32_t kSenderSsrc = 0x12345678; 26 const uint32_t kSenderSsrc = 0x12345678;
28 const uint32_t kRemoteSsrc = 0x23456789; 27 const uint32_t kRemoteSsrc = 0x23456789;
29 const uint32_t kBitrateBps = 312000; 28 const uint32_t kBitrateBps = 312000;
(...skipping 10 matching lines...) Expand all
40 EXPECT_EQ(length, header.BlockSize()); 39 EXPECT_EQ(length, header.BlockSize());
41 return tmmbn->Parse(header, buffer + RtcpCommonHeader::kHeaderSizeBytes); 40 return tmmbn->Parse(header, buffer + RtcpCommonHeader::kHeaderSizeBytes);
42 } 41 }
43 } // namespace 42 } // namespace
44 43
45 TEST(RtcpPacketTmmbnTest, Create) { 44 TEST(RtcpPacketTmmbnTest, Create) {
46 Tmmbn tmmbn; 45 Tmmbn tmmbn;
47 tmmbn.From(kSenderSsrc); 46 tmmbn.From(kSenderSsrc);
48 tmmbn.WithTmmbr(TmmbItem(kRemoteSsrc, kBitrateBps, kOverhead)); 47 tmmbn.WithTmmbr(TmmbItem(kRemoteSsrc, kBitrateBps, kOverhead));
49 48
50 rtc::scoped_ptr<RawPacket> packet = tmmbn.Build(); 49 rtc::Buffer packet = tmmbn.Build();
51 50
52 EXPECT_THAT(make_tuple(packet->Buffer(), packet->Length()), 51 EXPECT_THAT(make_tuple(packet.data(), packet.size()),
53 ElementsAreArray(kPacket)); 52 ElementsAreArray(kPacket));
54 } 53 }
55 54
56 TEST(RtcpPacketTmmbnTest, Parse) { 55 TEST(RtcpPacketTmmbnTest, Parse) {
57 Tmmbn tmmbn; 56 Tmmbn tmmbn;
58 EXPECT_TRUE(ParseTmmbn(kPacket, sizeof(kPacket), &tmmbn)); 57 EXPECT_TRUE(ParseTmmbn(kPacket, sizeof(kPacket), &tmmbn));
59 58
60 const Tmmbn& parsed = tmmbn; 59 const Tmmbn& parsed = tmmbn;
61 60
62 EXPECT_EQ(kSenderSsrc, parsed.sender_ssrc()); 61 EXPECT_EQ(kSenderSsrc, parsed.sender_ssrc());
63 ASSERT_EQ(1u, parsed.items().size()); 62 ASSERT_EQ(1u, parsed.items().size());
64 EXPECT_EQ(kRemoteSsrc, parsed.items().front().ssrc()); 63 EXPECT_EQ(kRemoteSsrc, parsed.items().front().ssrc());
65 EXPECT_EQ(kBitrateBps, parsed.items().front().bitrate_bps()); 64 EXPECT_EQ(kBitrateBps, parsed.items().front().bitrate_bps());
66 EXPECT_EQ(kOverhead, parsed.items().front().packet_overhead()); 65 EXPECT_EQ(kOverhead, parsed.items().front().packet_overhead());
67 } 66 }
68 67
69 TEST(RtcpPacketTmmbnTest, CreateAndParseWithoutItems) { 68 TEST(RtcpPacketTmmbnTest, CreateAndParseWithoutItems) {
70 Tmmbn tmmbn; 69 Tmmbn tmmbn;
71 tmmbn.From(kSenderSsrc); 70 tmmbn.From(kSenderSsrc);
72 71
73 rtc::scoped_ptr<RawPacket> packet = tmmbn.Build(); 72 rtc::Buffer packet = tmmbn.Build();
74 Tmmbn parsed; 73 Tmmbn parsed;
75 EXPECT_TRUE(ParseTmmbn(packet->Buffer(), packet->Length(), &parsed)); 74 EXPECT_TRUE(ParseTmmbn(packet.data(), packet.size(), &parsed));
76 75
77 EXPECT_EQ(kSenderSsrc, parsed.sender_ssrc()); 76 EXPECT_EQ(kSenderSsrc, parsed.sender_ssrc());
78 EXPECT_THAT(parsed.items(), IsEmpty()); 77 EXPECT_THAT(parsed.items(), IsEmpty());
79 } 78 }
80 79
81 TEST(RtcpPacketTmmbnTest, CreateAndParseWithTwoItems) { 80 TEST(RtcpPacketTmmbnTest, CreateAndParseWithTwoItems) {
82 Tmmbn tmmbn; 81 Tmmbn tmmbn;
83 tmmbn.From(kSenderSsrc); 82 tmmbn.From(kSenderSsrc);
84 tmmbn.WithTmmbr(TmmbItem(kRemoteSsrc, kBitrateBps, kOverhead)); 83 tmmbn.WithTmmbr(TmmbItem(kRemoteSsrc, kBitrateBps, kOverhead));
85 tmmbn.WithTmmbr(TmmbItem(kRemoteSsrc + 1, 4 * kBitrateBps, 40)); 84 tmmbn.WithTmmbr(TmmbItem(kRemoteSsrc + 1, 4 * kBitrateBps, 40));
86 85
87 rtc::scoped_ptr<RawPacket> packet = tmmbn.Build(); 86 rtc::Buffer packet = tmmbn.Build();
88 Tmmbn parsed; 87 Tmmbn parsed;
89 EXPECT_TRUE(ParseTmmbn(packet->Buffer(), packet->Length(), &parsed)); 88 EXPECT_TRUE(ParseTmmbn(packet.data(), packet.size(), &parsed));
90 89
91 EXPECT_EQ(kSenderSsrc, parsed.sender_ssrc()); 90 EXPECT_EQ(kSenderSsrc, parsed.sender_ssrc());
92 EXPECT_EQ(2u, parsed.items().size()); 91 EXPECT_EQ(2u, parsed.items().size());
93 EXPECT_EQ(kRemoteSsrc, parsed.items()[0].ssrc()); 92 EXPECT_EQ(kRemoteSsrc, parsed.items()[0].ssrc());
94 EXPECT_EQ(kBitrateBps, parsed.items()[0].bitrate_bps()); 93 EXPECT_EQ(kBitrateBps, parsed.items()[0].bitrate_bps());
95 EXPECT_EQ(kOverhead, parsed.items()[0].packet_overhead()); 94 EXPECT_EQ(kOverhead, parsed.items()[0].packet_overhead());
96 EXPECT_EQ(kRemoteSsrc + 1, parsed.items()[1].ssrc()); 95 EXPECT_EQ(kRemoteSsrc + 1, parsed.items()[1].ssrc());
97 EXPECT_EQ(4 * kBitrateBps, parsed.items()[1].bitrate_bps()); 96 EXPECT_EQ(4 * kBitrateBps, parsed.items()[1].bitrate_bps());
98 EXPECT_EQ(40U, parsed.items()[1].packet_overhead()); 97 EXPECT_EQ(40U, parsed.items()[1].packet_overhead());
99 } 98 }
100 99
101 TEST(RtcpPacketTmmbnTest, ParseFailsOnTooSmallPacket) { 100 TEST(RtcpPacketTmmbnTest, ParseFailsOnTooSmallPacket) {
102 const uint8_t kSmallPacket[] = {0x84, 205, 0x00, 0x01, 101 const uint8_t kSmallPacket[] = {0x84, 205, 0x00, 0x01,
103 0x12, 0x34, 0x56, 0x78}; 102 0x12, 0x34, 0x56, 0x78};
104 Tmmbn tmmbn; 103 Tmmbn tmmbn;
105 EXPECT_FALSE(ParseTmmbn(kSmallPacket, sizeof(kSmallPacket), &tmmbn)); 104 EXPECT_FALSE(ParseTmmbn(kSmallPacket, sizeof(kSmallPacket), &tmmbn));
106 } 105 }
107 106
108 TEST(RtcpPacketTmmbnTest, ParseFailsOnUnAlignedPacket) { 107 TEST(RtcpPacketTmmbnTest, ParseFailsOnUnAlignedPacket) {
109 const uint8_t kUnalignedPacket[] = {0x84, 205, 0x00, 0x03, 108 const uint8_t kUnalignedPacket[] = {0x84, 205, 0x00, 0x03,
110 0x12, 0x34, 0x56, 0x78, 109 0x12, 0x34, 0x56, 0x78,
111 0x00, 0x00, 0x00, 0x00, 110 0x00, 0x00, 0x00, 0x00,
112 0x23, 0x45, 0x67, 0x89}; 111 0x23, 0x45, 0x67, 0x89};
113 112
114 Tmmbn tmmbn; 113 Tmmbn tmmbn;
115 EXPECT_FALSE(ParseTmmbn(kUnalignedPacket, sizeof(kUnalignedPacket), &tmmbn)); 114 EXPECT_FALSE(ParseTmmbn(kUnalignedPacket, sizeof(kUnalignedPacket), &tmmbn));
116 } 115 }
117 } // namespace webrtc 116 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698