Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/sli_unittest.cc

Issue 1696203002: [rtp_rtcp] rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/sli_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/sli_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/sli_unittest.cc
index c2be16846b62ed50e0a8b9e2416625a92fce6726..e145a6d2e9e5ee73d4316e0ee86393fb14514ea6 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/sli_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/sli_unittest.cc
@@ -15,7 +15,6 @@
using testing::ElementsAreArray;
using testing::make_tuple;
-using webrtc::rtcp::RawPacket;
using webrtc::rtcp::Sli;
using webrtc::RTCPUtility::RtcpCommonHeader;
using webrtc::RTCPUtility::RtcpParseCommonHeader;
@@ -56,9 +55,9 @@ TEST(RtcpPacketSliTest, Create) {
sli.To(kRemoteSsrc);
sli.WithPictureId(kPictureId, kFirstMb, kNumberOfMb);
- rtc::scoped_ptr<RawPacket> packet(sli.Build());
+ rtc::Buffer packet = sli.Build();
- EXPECT_THAT(make_tuple(packet->Buffer(), packet->Length()),
+ EXPECT_THAT(make_tuple(packet.data(), packet.size()),
ElementsAreArray(kPacket));
}
@@ -81,10 +80,10 @@ TEST(RtcpPacketSliTest, ParseFailsOnTooSmallPacket) {
sli.To(kRemoteSsrc);
sli.WithPictureId(kPictureId, kFirstMb, kNumberOfMb);
- rtc::scoped_ptr<RawPacket> packet(sli.Build());
- packet->MutableBuffer()[3]--; // Decrease size by 1 word (4 bytes).
+ rtc::Buffer packet = sli.Build();
+ packet.data()[3]--; // Decrease size by 1 word (4 bytes).
- EXPECT_FALSE(ParseSli(packet->Buffer(), packet->Length() - 4, &sli));
+ EXPECT_FALSE(ParseSli(packet.data(), packet.size() - 4, &sli));
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698