Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet.cc

Issue 1696203002: [rtp_rtcp] rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet.cc
index eaaa78c2f0a7ea3d92ee96272b0eef72875c8bce..b69f50712760d9f2384265eba2d235942b06baa2 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet.cc
@@ -31,28 +31,27 @@ void RtcpPacket::Append(RtcpPacket* packet) {
appended_packets_.push_back(packet);
}
-rtc::scoped_ptr<RawPacket> RtcpPacket::Build() const {
+rtc::Buffer RtcpPacket::Build() const {
size_t length = 0;
- rtc::scoped_ptr<RawPacket> packet(new RawPacket(IP_PACKET_SIZE));
+ rtc::Buffer packet(IP_PACKET_SIZE);
class PacketVerifier : public PacketReadyCallback {
public:
- explicit PacketVerifier(RawPacket* packet)
+ explicit PacketVerifier(rtc::Buffer* packet)
: called_(false), packet_(packet) {}
virtual ~PacketVerifier() {}
void OnPacketReady(uint8_t* data, size_t length) override {
RTC_CHECK(!called_) << "Fragmentation not supported.";
called_ = true;
- packet_->SetLength(length);
+ packet_->SetSize(length);
}
private:
bool called_;
- RawPacket* const packet_;
- } verifier(packet.get());
- CreateAndAddAppended(packet->MutableBuffer(), &length, packet->BufferLength(),
- &verifier);
- OnBufferFull(packet->MutableBuffer(), &length, &verifier);
+ rtc::Buffer* const packet_;
+ } verifier(&packet);
+ CreateAndAddAppended(packet.data(), &length, packet.capacity(), &verifier);
+ OnBufferFull(packet.data(), &length, &verifier);
return packet;
}
@@ -122,37 +121,5 @@ void RtcpPacket::CreateHeader(
AssignUWord16(buffer, pos, length);
}
-RawPacket::RawPacket(size_t buffer_length)
- : buffer_length_(buffer_length), length_(0) {
- buffer_.reset(new uint8_t[buffer_length]);
-}
-
-RawPacket::RawPacket(const uint8_t* packet, size_t packet_length)
- : buffer_length_(packet_length), length_(packet_length) {
- buffer_.reset(new uint8_t[packet_length]);
- memcpy(buffer_.get(), packet, packet_length);
-}
-
-const uint8_t* RawPacket::Buffer() const {
- return buffer_.get();
-}
-
-uint8_t* RawPacket::MutableBuffer() {
- return buffer_.get();
-}
-
-size_t RawPacket::BufferLength() const {
- return buffer_length_;
-}
-
-size_t RawPacket::Length() const {
- return length_;
-}
-
-void RawPacket::SetLength(size_t length) {
- assert(length <= buffer_length_);
- length_ = length;
-}
-
} // namespace rtcp
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698