Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr_unittest.cc

Issue 1696203002: [rtp_rtcp] rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.h" 11 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.h"
12 12
13 #include "testing/gmock/include/gmock/gmock.h" 13 #include "testing/gmock/include/gmock/gmock.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 15
16 using testing::ElementsAreArray; 16 using testing::ElementsAreArray;
17 using testing::IsEmpty; 17 using testing::IsEmpty;
18 using testing::make_tuple; 18 using testing::make_tuple;
19 using webrtc::rtcp::RawPacket;
20 using webrtc::rtcp::TmmbItem; 19 using webrtc::rtcp::TmmbItem;
21 using webrtc::rtcp::Tmmbr; 20 using webrtc::rtcp::Tmmbr;
22 using webrtc::RTCPUtility::RtcpCommonHeader; 21 using webrtc::RTCPUtility::RtcpCommonHeader;
23 using webrtc::RTCPUtility::RtcpParseCommonHeader; 22 using webrtc::RTCPUtility::RtcpParseCommonHeader;
24 23
25 namespace webrtc { 24 namespace webrtc {
26 namespace { 25 namespace {
27 const uint32_t kSenderSsrc = 0x12345678; 26 const uint32_t kSenderSsrc = 0x12345678;
28 const uint32_t kRemoteSsrc = 0x23456789; 27 const uint32_t kRemoteSsrc = 0x23456789;
29 const uint32_t kBitrateBps = 312000; 28 const uint32_t kBitrateBps = 312000;
(...skipping 10 matching lines...) Expand all
40 EXPECT_EQ(length, header.BlockSize()); 39 EXPECT_EQ(length, header.BlockSize());
41 return tmmbr->Parse(header, buffer + RtcpCommonHeader::kHeaderSizeBytes); 40 return tmmbr->Parse(header, buffer + RtcpCommonHeader::kHeaderSizeBytes);
42 } 41 }
43 } // namespace 42 } // namespace
44 43
45 TEST(RtcpPacketTmmbrTest, Create) { 44 TEST(RtcpPacketTmmbrTest, Create) {
46 Tmmbr tmmbr; 45 Tmmbr tmmbr;
47 tmmbr.From(kSenderSsrc); 46 tmmbr.From(kSenderSsrc);
48 tmmbr.WithTmmbr(TmmbItem(kRemoteSsrc, kBitrateBps, kOverhead)); 47 tmmbr.WithTmmbr(TmmbItem(kRemoteSsrc, kBitrateBps, kOverhead));
49 48
50 rtc::scoped_ptr<RawPacket> packet = tmmbr.Build(); 49 rtc::Buffer packet = tmmbr.Build();
51 50
52 EXPECT_THAT(make_tuple(packet->Buffer(), packet->Length()), 51 EXPECT_THAT(make_tuple(packet.data(), packet.size()),
53 ElementsAreArray(kPacket)); 52 ElementsAreArray(kPacket));
54 } 53 }
55 54
56 TEST(RtcpPacketTmmbrTest, Parse) { 55 TEST(RtcpPacketTmmbrTest, Parse) {
57 Tmmbr tmmbr; 56 Tmmbr tmmbr;
58 EXPECT_TRUE(ParseTmmbr(kPacket, sizeof(kPacket), &tmmbr)); 57 EXPECT_TRUE(ParseTmmbr(kPacket, sizeof(kPacket), &tmmbr));
59 const Tmmbr& parsed = tmmbr; 58 const Tmmbr& parsed = tmmbr;
60 59
61 EXPECT_EQ(kSenderSsrc, parsed.sender_ssrc()); 60 EXPECT_EQ(kSenderSsrc, parsed.sender_ssrc());
62 ASSERT_EQ(1u, parsed.requests().size()); 61 ASSERT_EQ(1u, parsed.requests().size());
63 EXPECT_EQ(kRemoteSsrc, parsed.requests().front().ssrc()); 62 EXPECT_EQ(kRemoteSsrc, parsed.requests().front().ssrc());
64 EXPECT_EQ(kBitrateBps, parsed.requests().front().bitrate_bps()); 63 EXPECT_EQ(kBitrateBps, parsed.requests().front().bitrate_bps());
65 EXPECT_EQ(kOverhead, parsed.requests().front().packet_overhead()); 64 EXPECT_EQ(kOverhead, parsed.requests().front().packet_overhead());
66 } 65 }
67 66
68 TEST(RtcpPacketTmmbrTest, CreateAndParseWithTwoEntries) { 67 TEST(RtcpPacketTmmbrTest, CreateAndParseWithTwoEntries) {
69 Tmmbr tmmbr; 68 Tmmbr tmmbr;
70 tmmbr.From(kSenderSsrc); 69 tmmbr.From(kSenderSsrc);
71 tmmbr.WithTmmbr(TmmbItem(kRemoteSsrc, kBitrateBps, kOverhead)); 70 tmmbr.WithTmmbr(TmmbItem(kRemoteSsrc, kBitrateBps, kOverhead));
72 tmmbr.WithTmmbr(TmmbItem(kRemoteSsrc + 1, 4 * kBitrateBps, kOverhead + 1)); 71 tmmbr.WithTmmbr(TmmbItem(kRemoteSsrc + 1, 4 * kBitrateBps, kOverhead + 1));
73 72
74 rtc::scoped_ptr<RawPacket> packet = tmmbr.Build(); 73 rtc::Buffer packet = tmmbr.Build();
75 74
76 Tmmbr parsed; 75 Tmmbr parsed;
77 EXPECT_TRUE(ParseTmmbr(packet->Buffer(), packet->Length(), &parsed)); 76 EXPECT_TRUE(ParseTmmbr(packet.data(), packet.size(), &parsed));
78 77
79 EXPECT_EQ(kSenderSsrc, parsed.sender_ssrc()); 78 EXPECT_EQ(kSenderSsrc, parsed.sender_ssrc());
80 EXPECT_EQ(2u, parsed.requests().size()); 79 EXPECT_EQ(2u, parsed.requests().size());
81 EXPECT_EQ(kRemoteSsrc, parsed.requests()[0].ssrc()); 80 EXPECT_EQ(kRemoteSsrc, parsed.requests()[0].ssrc());
82 EXPECT_EQ(kRemoteSsrc + 1, parsed.requests()[1].ssrc()); 81 EXPECT_EQ(kRemoteSsrc + 1, parsed.requests()[1].ssrc());
83 } 82 }
84 83
85 TEST(RtcpPacketTmmbrTest, ParseFailsWithoutItems) { 84 TEST(RtcpPacketTmmbrTest, ParseFailsWithoutItems) {
86 const uint8_t kZeroItemsPacket[] = {0x83, 205, 0x00, 0x02, 85 const uint8_t kZeroItemsPacket[] = {0x83, 205, 0x00, 0x02,
87 0x12, 0x34, 0x56, 0x78, 86 0x12, 0x34, 0x56, 0x78,
88 0x00, 0x00, 0x00, 0x00}; 87 0x00, 0x00, 0x00, 0x00};
89 88
90 Tmmbr tmmbr; 89 Tmmbr tmmbr;
91 EXPECT_FALSE(ParseTmmbr(kZeroItemsPacket, sizeof(kZeroItemsPacket), &tmmbr)); 90 EXPECT_FALSE(ParseTmmbr(kZeroItemsPacket, sizeof(kZeroItemsPacket), &tmmbr));
92 } 91 }
93 92
94 TEST(RtcpPacketTmmbrTest, ParseFailsOnUnAlignedPacket) { 93 TEST(RtcpPacketTmmbrTest, ParseFailsOnUnAlignedPacket) {
95 const uint8_t kUnalignedPacket[] = {0x83, 205, 0x00, 0x05, 94 const uint8_t kUnalignedPacket[] = {0x83, 205, 0x00, 0x05,
96 0x12, 0x34, 0x56, 0x78, 95 0x12, 0x34, 0x56, 0x78,
97 0x00, 0x00, 0x00, 0x00, 96 0x00, 0x00, 0x00, 0x00,
98 0x23, 0x45, 0x67, 0x89, 97 0x23, 0x45, 0x67, 0x89,
99 0x0a, 0x61, 0x61, 0xfe, 98 0x0a, 0x61, 0x61, 0xfe,
100 0x34, 0x56, 0x78, 0x9a}; 99 0x34, 0x56, 0x78, 0x9a};
101 100
102 Tmmbr tmmbr; 101 Tmmbr tmmbr;
103 EXPECT_FALSE(ParseTmmbr(kUnalignedPacket, sizeof(kUnalignedPacket), &tmmbr)); 102 EXPECT_FALSE(ParseTmmbr(kUnalignedPacket, sizeof(kUnalignedPacket), &tmmbr));
104 } 103 }
105 } // namespace webrtc 104 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698