Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1540)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc

Issue 1696203002: [rtp_rtcp] rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc
index 09d7b6305f39d67c6bce797ac64d6ee6984620aa..43a4fed0a4fdd54cf1240b137ee4b8ec931d1f0c 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc
@@ -15,7 +15,6 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "webrtc/modules/rtp_rtcp/source/rtcp_utility.h"
-using webrtc::rtcp::RawPacket;
using webrtc::rtcp::ExtendedJitterReport;
using webrtc::RTCPUtility::RtcpCommonHeader;
using webrtc::RTCPUtility::RtcpParseCommonHeader;
@@ -28,15 +27,14 @@ class RtcpPacketExtendedJitterReportTest : public ::testing::Test {
void BuildPacket() { packet = ij.Build(); }
void ParsePacket() {
RtcpCommonHeader header;
- EXPECT_TRUE(
- RtcpParseCommonHeader(packet->Buffer(), packet->Length(), &header));
- EXPECT_EQ(header.BlockSize(), packet->Length());
+ EXPECT_TRUE(RtcpParseCommonHeader(packet.data(), packet.size(), &header));
+ EXPECT_EQ(header.BlockSize(), packet.size());
EXPECT_TRUE(parsed_.Parse(
- header, packet->Buffer() + RtcpCommonHeader::kHeaderSizeBytes));
+ header, packet.data() + RtcpCommonHeader::kHeaderSizeBytes));
}
ExtendedJitterReport ij;
- rtc::scoped_ptr<RawPacket> packet;
+ rtc::Buffer packet;
const ExtendedJitterReport& parsed() { return parsed_; }
private:
@@ -85,13 +83,13 @@ TEST_F(RtcpPacketExtendedJitterReportTest, ParseFailWithTooManyItems) {
ij.WithJitter(0x11121418);
BuildPacket();
RtcpCommonHeader header;
- RtcpParseCommonHeader(packet->Buffer(), packet->Length(), &header);
+ RtcpParseCommonHeader(packet.data(), packet.size(), &header);
header.count_or_format++; // Damage package.
ExtendedJitterReport parsed;
EXPECT_FALSE(parsed.Parse(
- header, packet->Buffer() + RtcpCommonHeader::kHeaderSizeBytes));
+ header, packet.data() + RtcpCommonHeader::kHeaderSizeBytes));
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698