Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc

Issue 1696203002: [rtp_rtcp] rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc
index e18c208921246d07db60b8ef990d4ed62eaf2d49..ee06972e2b052dd670fc9427e4a1759b11cbc93c 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc
@@ -16,7 +16,6 @@
using testing::ElementsAreArray;
using testing::IsEmpty;
using testing::make_tuple;
-using webrtc::rtcp::RawPacket;
using webrtc::rtcp::Remb;
using webrtc::RTCPUtility::RtcpCommonHeader;
using webrtc::RTCPUtility::RtcpParseCommonHeader;
@@ -48,9 +47,9 @@ TEST(RtcpPacketRembTest, Create) {
remb.AppliesTo(kRemoteSsrcs[2]);
remb.WithBitrateBps(kBitrateBps);
- rtc::scoped_ptr<RawPacket> packet(remb.Build());
+ rtc::Buffer packet = remb.Build();
- EXPECT_THAT(make_tuple(packet->Buffer(), packet->Length()),
+ EXPECT_THAT(make_tuple(packet.data(), packet.size()),
ElementsAreArray(kPacket));
}
@@ -68,10 +67,10 @@ TEST(RtcpPacketRembTest, CreateAndParseWithoutSsrcs) {
Remb remb;
remb.From(kSenderSsrc);
remb.WithBitrateBps(kBitrateBps);
- rtc::scoped_ptr<RawPacket> packet(remb.Build());
+ rtc::Buffer packet = remb.Build();
Remb parsed;
- EXPECT_TRUE(ParseRemb(packet->Buffer(), packet->Length(), &parsed));
+ EXPECT_TRUE(ParseRemb(packet.data(), packet.size(), &parsed));
EXPECT_EQ(kSenderSsrc, parsed.sender_ssrc());
EXPECT_EQ(kBitrateBps, parsed.bitrate_bps());
EXPECT_THAT(parsed.ssrcs(), IsEmpty());

Powered by Google App Engine
This is Rietveld 408576698